Make sure last successful node is not executed twice when restoring from Persistence checkpoints #1308
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rom Persistence checkpoints
Member
|
That sounds reasonable, but there are a bunch of tests to fix |
Qodana for JVM1256 new problems were found
@@ Code coverage @@
+ 72% total lines covered
18140 lines analyzed, 13076 lines covered
# Calculated according to the filters of your coverage tool☁️ View the detailed Qodana report Contact Qodana teamContact us at [email protected]
|
Rizzen
approved these changes
Jan 6, 2026
15 tasks
aozherelyeva
added a commit
that referenced
this pull request
Jan 7, 2026
<!-- Thank you for opening a pull request! Please add a brief description of the proposed change here. Also, please tick the appropriate points in the checklist below. --> ## Motivation and Context <!-- Why is this change needed? What problem does it solve? --> - Skip Google LLMProvider because of a [bug](googleapis/python-genai#1723); - Adjust rollback test expectations after a [fix](#1308); - Update a QWEN profile used in OpenRouterModels to less flaky. ## Breaking Changes <!-- Will users need to update their code or configurations? --> --- #### Type of the changes - [ ] New feature (non-breaking change which adds functionality) - [ ] Bug fix (non-breaking change which fixes an issue) - [ ] Breaking change (fix or feature that would cause existing functionality to change) - [ ] Documentation update - [x] Tests improvement - [ ] Refactoring #### Checklist - [x] The pull request has a description of the proposed change - [x] I read the [Contributing Guidelines](https://github.com/JetBrains/koog/blob/main/CONTRIBUTING.md) before opening the pull request - [x] The pull request uses **`develop`** as the base branch - [x] Tests for the changes have been added - [x] All new and existing tests passed ##### Additional steps for pull requests adding a new feature - [ ] An issue describing the proposed change exists - [ ] The pull request includes a link to the issue - [ ] The change was discussed and approved in the issue - [ ] Docs have been added / updated
karloti
pushed a commit
to karloti/koog
that referenced
this pull request
Jan 7, 2026
…rom Persistence checkpoints (JetBrains#1308) Make sure last successful node is not executed twice when restoring from Persistence checkpoints ## Motivation and Context Previously, if latest node was a successful tool call or any other operation with a side-effect, it was re-executed again although we could've reused the latest successful result. The reason behind that was becaused internally input was required to restore the full subgraph structure. In this PR, `lastInput` field of the checkpoints was changed to `lastOutput`, and `resolveEdge()` method was used in order to restore the NEXT node with the correct input instead of the current node. ## Breaking Changes In checkpoints structure, `lastInput` field was changed to `lastOutput` --- #### Type of the changes - [ ] New feature (non-breaking change which adds functionality) - [x] Bug fix (non-breaking change which fixes an issue) - [ ] Breaking change (fix or feature that would cause existing functionality to change) - [ ] Documentation update - [ ] Tests improvement - [ ] Refactoring #### Checklist - [ ] The pull request has a description of the proposed change - [ ] I read the [Contributing Guidelines](https://github.com/JetBrains/koog/blob/main/CONTRIBUTING.md) before opening the pull request - [ ] The pull request uses **`develop`** as the base branch - [ ] Tests for the changes have been added - [ ] All new and existing tests passed ##### Additional steps for pull requests adding a new feature - [ ] An issue describing the proposed change exists - [ ] The pull request includes a link to the issue - [ ] The change was discussed and approved in the issue - [ ] Docs have been added / updated
karloti
pushed a commit
to karloti/koog
that referenced
this pull request
Jan 7, 2026
<!-- Thank you for opening a pull request! Please add a brief description of the proposed change here. Also, please tick the appropriate points in the checklist below. --> ## Motivation and Context <!-- Why is this change needed? What problem does it solve? --> - Skip Google LLMProvider because of a [bug](googleapis/python-genai#1723); - Adjust rollback test expectations after a [fix](JetBrains#1308); - Update a QWEN profile used in OpenRouterModels to less flaky. ## Breaking Changes <!-- Will users need to update their code or configurations? --> --- #### Type of the changes - [ ] New feature (non-breaking change which adds functionality) - [ ] Bug fix (non-breaking change which fixes an issue) - [ ] Breaking change (fix or feature that would cause existing functionality to change) - [ ] Documentation update - [x] Tests improvement - [ ] Refactoring #### Checklist - [x] The pull request has a description of the proposed change - [x] I read the [Contributing Guidelines](https://github.com/JetBrains/koog/blob/main/CONTRIBUTING.md) before opening the pull request - [x] The pull request uses **`develop`** as the base branch - [x] Tests for the changes have been added - [x] All new and existing tests passed ##### Additional steps for pull requests adding a new feature - [ ] An issue describing the proposed change exists - [ ] The pull request includes a link to the issue - [ ] The change was discussed and approved in the issue - [ ] Docs have been added / updated
vova-jb
pushed a commit
that referenced
this pull request
Jan 27, 2026
…rom Persistence checkpoints (#1308) Make sure last successful node is not executed twice when restoring from Persistence checkpoints ## Motivation and Context Previously, if latest node was a successful tool call or any other operation with a side-effect, it was re-executed again although we could've reused the latest successful result. The reason behind that was becaused internally input was required to restore the full subgraph structure. In this PR, `lastInput` field of the checkpoints was changed to `lastOutput`, and `resolveEdge()` method was used in order to restore the NEXT node with the correct input instead of the current node. ## Breaking Changes In checkpoints structure, `lastInput` field was changed to `lastOutput` --- #### Type of the changes - [ ] New feature (non-breaking change which adds functionality) - [x] Bug fix (non-breaking change which fixes an issue) - [ ] Breaking change (fix or feature that would cause existing functionality to change) - [ ] Documentation update - [ ] Tests improvement - [ ] Refactoring #### Checklist - [ ] The pull request has a description of the proposed change - [ ] I read the [Contributing Guidelines](https://github.com/JetBrains/koog/blob/main/CONTRIBUTING.md) before opening the pull request - [ ] The pull request uses **`develop`** as the base branch - [ ] Tests for the changes have been added - [ ] All new and existing tests passed ##### Additional steps for pull requests adding a new feature - [ ] An issue describing the proposed change exists - [ ] The pull request includes a link to the issue - [ ] The change was discussed and approved in the issue - [ ] Docs have been added / updated
vova-jb
pushed a commit
that referenced
this pull request
Jan 27, 2026
<!-- Thank you for opening a pull request! Please add a brief description of the proposed change here. Also, please tick the appropriate points in the checklist below. --> ## Motivation and Context <!-- Why is this change needed? What problem does it solve? --> - Skip Google LLMProvider because of a [bug](googleapis/python-genai#1723); - Adjust rollback test expectations after a [fix](#1308); - Update a QWEN profile used in OpenRouterModels to less flaky. ## Breaking Changes <!-- Will users need to update their code or configurations? --> --- #### Type of the changes - [ ] New feature (non-breaking change which adds functionality) - [ ] Bug fix (non-breaking change which fixes an issue) - [ ] Breaking change (fix or feature that would cause existing functionality to change) - [ ] Documentation update - [x] Tests improvement - [ ] Refactoring #### Checklist - [x] The pull request has a description of the proposed change - [x] I read the [Contributing Guidelines](https://github.com/JetBrains/koog/blob/main/CONTRIBUTING.md) before opening the pull request - [x] The pull request uses **`develop`** as the base branch - [x] Tests for the changes have been added - [x] All new and existing tests passed ##### Additional steps for pull requests adding a new feature - [ ] An issue describing the proposed change exists - [ ] The pull request includes a link to the issue - [ ] The change was discussed and approved in the issue - [ ] Docs have been added / updated
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make sure last successful node is not executed twice when restoring from Persistence checkpoints
Motivation and Context
Previously, if latest node was a successful tool call or any other operation with a side-effect, it was re-executed again although we could've reused the latest successful result. The reason behind that was becaused internally input was required to restore the full subgraph structure.
In this PR,
lastInputfield of the checkpoints was changed tolastOutput, andresolveEdge()method was used in order to restore the NEXT node with the correct input instead of the current node.Breaking Changes
In checkpoints structure,
lastInputfield was changed tolastOutputType of the changes
Checklist
developas the base branchAdditional steps for pull requests adding a new feature