Improve acceptVoid performances
#5630
Conversation
…neBuilder` This would have caused issues when adding `acceptVoid` to `IrElement` KT-74618
KT-74618
KT-74618 Fixed
francescoo22
requested review from
a team,
ShikaSD,
andrewbailey,
bentrengrove,
blueshiftlabs,
bnorm,
broadwaylamb,
chuckjaz,
derekxu16,
jaschdoc,
jsjeon,
sandwwraith,
shanshin,
ting-yuan and
troelsbjerre
as code owners
francescoo22
requested review from
andrey-mogilev,
anton-bannykh,
bashor and
marcopennekamp
|
These are the results for Intellij project. Lowering time is visibly improved and overall time looks slightly improved. |
|
These are the results for Full Kotlin. Overall time seems higher than last builds, but still aligned with previous ones. This looks to be caused by analysis time that shouldn't be affected by my changes. So, perhaps it is just noise, but I'm not sure. |
| this.body() | ||
| return this | ||
| } | ||
|
|
||
| protected fun IrElement.transformChildrenVoid() { |
There was a problem hiding this comment.
Why do we remove this function? It is used a lot, and quite handy? As you probably have only a single Transformer in code in most cases, and passing correct this is not very useful for readability.
| override fun <D> transform(transformer: IrTransformer<D>, data: D): IrBranch = | ||
| accept(transformer, data) as IrBranch | ||
|
|
||
| override fun transformVoid(transformer: IrElementTransformerVoid): IrBranch = | ||
| accept(transformer, null) as IrBranch |
There was a problem hiding this comment.
Why are we not calling acceptVoid here?
This should save 2 calls on the call stack when calling
acceptVoid,acceptChildrenVoid,transformVoidandtransformChildrenVoidmethods.Example:
Before:
irBody.acceptVoid(visitor)->IrElement.acceptVoid(visitor)->IrBlockBody.accept(visitor, null)->IrVisitorVoid.visitBlockBody(visitBlockBody, null)->IrVisitorVoid.visitBlockBody(visitBlockBody)Now:
irBody.acceptVoid(visitor)->IrBlockBody.acceptVoid(visitor)->IrVisitorVoid.visitBlockBody(visitBlockBody)