Improve acceptVoid performances

analysis/analysis-api-impl-base/testFixtures/org/jetbrains/kotlin/analysis/api/impl/base/test/cases/components/compilerFacility/AbstractCompilerFacilityTest.kt

@@ -36,7 +36,6 @@ import org.jetbrains.kotlin.ir.symbols.UnsafeDuringIrConstructionAPI
 import org.jetbrains.kotlin.ir.util.DumpIrTreeOptions
 import org.jetbrains.kotlin.ir.util.dump
 import org.jetbrains.kotlin.ir.visitors.IrVisitorVoid
-import org.jetbrains.kotlin.ir.visitors.acceptChildrenVoid
 import org.jetbrains.kotlin.name.ClassId
 import org.jetbrains.kotlin.name.FqName
 import org.jetbrains.kotlin.name.FqNameUnsafe

compiler/cli/cli-js/src/org/jetbrains/kotlin/cli/pipeline/web/WebFir2IrPipelinePhase.kt

@@ -31,7 +31,6 @@ import org.jetbrains.kotlin.ir.backend.js.getSerializedData
 import org.jetbrains.kotlin.ir.backend.js.lower.serialization.ir.JsManglerIr
 import org.jetbrains.kotlin.ir.backend.js.lower.serialization.ir.collectJsExportNames
 import org.jetbrains.kotlin.ir.types.IrTypeSystemContextImpl
-import org.jetbrains.kotlin.ir.visitors.acceptVoid
 import org.jetbrains.kotlin.js.config.incrementalDataProvider
 import org.jetbrains.kotlin.js.config.wasmCompilation
 import org.jetbrains.kotlin.library.isJsStdlib

compiler/fir/analysis-tests/testFixtures/org/jetbrains/kotlin/test/runners/AbstractFirLoadCompiledJvmWithAnnotationsInMetadataKotlinTest.kt

@@ -15,8 +15,6 @@ import org.jetbrains.kotlin.ir.IrElement
 import org.jetbrains.kotlin.ir.declarations.IrDeclaration
 import org.jetbrains.kotlin.ir.declarations.IrModuleFragment
 import org.jetbrains.kotlin.ir.visitors.IrVisitorVoid
-import org.jetbrains.kotlin.ir.visitors.acceptChildrenVoid
-import org.jetbrains.kotlin.ir.visitors.acceptVoid
 import org.jetbrains.kotlin.test.builders.TestConfigurationBuilder
 import org.jetbrains.kotlin.test.directives.LanguageSettingsDirectives
 import org.jetbrains.kotlin.test.directives.model.SimpleDirective

compiler/fir/entrypoint/src/org/jetbrains/kotlin/fir/pipeline/convertToIr.kt

@@ -53,8 +53,6 @@ import org.jetbrains.kotlin.ir.validation.validateIr
 import org.jetbrains.kotlin.ir.validation.withBasicChecks
 import org.jetbrains.kotlin.ir.validation.withVarargChecks
 import org.jetbrains.kotlin.ir.visitors.IrVisitorVoid
-import org.jetbrains.kotlin.ir.visitors.acceptChildrenVoid
-import org.jetbrains.kotlin.ir.visitors.acceptVoid
 import org.jetbrains.kotlin.platform.jvm.isJvm
 import org.jetbrains.kotlin.utils.addToStdlib.applyIf
 import org.jetbrains.kotlin.utils.addToStdlib.runIf

compiler/ir/backend.common/src/org/jetbrains/kotlin/backend/common/Lower.kt

@@ -25,8 +25,6 @@ import org.jetbrains.kotlin.ir.util.transformFlat
 import org.jetbrains.kotlin.ir.util.transformSubsetFlat
 import org.jetbrains.kotlin.ir.visitors.IrVisitor
 import org.jetbrains.kotlin.ir.visitors.IrVisitorVoid
-import org.jetbrains.kotlin.ir.visitors.acceptChildrenVoid
-import org.jetbrains.kotlin.ir.visitors.acceptVoid
 import org.jetbrains.kotlin.utils.KotlinExceptionWithAttachments
 
 interface ModuleLoweringPass {

compiler/ir/backend.common/src/org/jetbrains/kotlin/backend/common/ir/IrInlineUtils.kt

@@ -95,7 +95,7 @@ private fun IrBody.move(
         // Might be an inline lambda argument; if the function has already been moved out, visit it explicitly.
         if (expression.origin == IrStatementOrigin.LAMBDA || expression.origin == IrStatementOrigin.ANONYMOUS_FUNCTION)
             if (expression.statements.lastOrNull() is IrFunctionReference && expression.statements.none { it is IrFunction })
-                (expression.statements.last() as IrFunctionReference).symbol.owner.transformChildrenVoid()
+                (expression.statements.last() as IrFunctionReference).symbol.owner.transformChildrenVoid(this)
         return super.visitBlock(expression)
     }
 

compiler/ir/backend.common/src/org/jetbrains/kotlin/backend/common/ir/ValueRemapper.kt

@@ -24,7 +24,7 @@ abstract class AbstractValueRemapper : IrElementTransformerVoid() {
     }
 
     override fun visitSetValue(expression: IrSetValue): IrExpression {
-        expression.transformChildrenVoid()
+        expression.transformChildrenVoid(this)
         val newValue = remapValue(expression.symbol) ?: return expression
         assert(newValue.owner.isAssignable)
         return expression.run { IrSetValueImpl(startOffset, endOffset, type, newValue, value, origin) }

compiler/ir/backend.common/src/org/jetbrains/kotlin/backend/common/lower/AbstractPropertyReferenceLowering.kt

@@ -25,7 +25,6 @@ import org.jetbrains.kotlin.ir.types.classOrFail
 import org.jetbrains.kotlin.ir.types.typeOrNull
 import org.jetbrains.kotlin.ir.types.typeWith
 import org.jetbrains.kotlin.ir.util.selectSAMOverriddenFunction
-import org.jetbrains.kotlin.ir.visitors.transformChildrenVoid
 import org.jetbrains.kotlin.utils.addToStdlib.shouldNotBeCalled
 
 abstract class AbstractPropertyReferenceLowering<C : CommonBackendContext>(val context: C) : FileLoweringPass {

compiler/ir/backend.common/src/org/jetbrains/kotlin/backend/common/lower/AbstractValueUsageTransformer.kt

@@ -17,7 +17,6 @@ import org.jetbrains.kotlin.ir.symbols.IrReturnableBlockSymbol
 import org.jetbrains.kotlin.ir.symbols.IrSimpleFunctionSymbol
 import org.jetbrains.kotlin.ir.types.IrType
 import org.jetbrains.kotlin.ir.visitors.IrElementTransformerVoid
-import org.jetbrains.kotlin.ir.visitors.transformChildrenVoid
 import org.jetbrains.kotlin.utils.addToStdlib.assignFrom
 
 
@@ -255,7 +254,7 @@ abstract class AbstractValueUsageTransformer(
     }
 
     override fun visitStringConcatenation(expression: IrStringConcatenation): IrExpression {
-        expression.transformChildrenVoid()
+        expression.transformChildrenVoid(this)
         if (expression is IrStringConcatenationImpl) {
             for ((i, arg) in expression.arguments.withIndex()) {
                 expression.arguments[i] = arg.useAs(irBuiltIns.anyNType)

compiler/ir/backend.common/src/org/jetbrains/kotlin/backend/common/lower/AnnotationImplementationTransformer.kt

@@ -28,7 +28,6 @@ import org.jetbrains.kotlin.ir.types.IrType
 import org.jetbrains.kotlin.ir.types.classOrNull
 import org.jetbrains.kotlin.ir.types.isArray
 import org.jetbrains.kotlin.ir.util.*
-import org.jetbrains.kotlin.ir.visitors.transformChildrenVoid
 import org.jetbrains.kotlin.name.Name
 import org.jetbrains.kotlin.utils.filterIsInstanceAnd
 
@@ -114,7 +113,7 @@ abstract class AnnotationImplementationTransformer(val context: CommonBackendCon
             ctor.symbol,
         )
         moveValueArgumentsUsingNames(expression, newCall)
-        newCall.transformChildrenVoid() // for annotations in annotations
+        newCall.transformChildrenVoid(this) // for annotations in annotations
         return newCall
     }
 

compiler/ir/backend.common/src/org/jetbrains/kotlin/backend/common/lower/ArrayConstructorLowering.kt

@@ -16,7 +16,6 @@ import org.jetbrains.kotlin.ir.expressions.*
 import org.jetbrains.kotlin.ir.symbols.IrFunctionSymbol
 import org.jetbrains.kotlin.ir.types.*
 import org.jetbrains.kotlin.ir.util.*
-import org.jetbrains.kotlin.ir.visitors.transformChildrenVoid
 import org.jetbrains.kotlin.util.OperatorNameConventions
 
 /**

compiler/ir/backend.common/src/org/jetbrains/kotlin/backend/common/lower/DefaultArgumentStubGenerator.kt

@@ -26,7 +26,6 @@ import org.jetbrains.kotlin.ir.types.defaultType
 import org.jetbrains.kotlin.ir.types.makeNullable
 import org.jetbrains.kotlin.ir.util.*
 import org.jetbrains.kotlin.ir.visitors.IrElementTransformerVoid
-import org.jetbrains.kotlin.ir.visitors.transformChildrenVoid
 import org.jetbrains.kotlin.util.OperatorNameConventions
 import org.jetbrains.kotlin.utils.addToStdlib.assignFrom
 import org.jetbrains.kotlin.utils.memoryOptimizedPlus
@@ -289,7 +288,7 @@ open class DefaultParameterInjector<TContext : CommonBackendContext>(
         isStatic(declaration) && declaration.parentAsClass.isMultiFieldValueClass && declaration is IrSimpleFunction
 
     override fun visitDelegatingConstructorCall(expression: IrDelegatingConstructorCall): IrExpression {
-        expression.transformChildrenVoid()
+        expression.transformChildrenVoid(this)
         return visitFunctionAccessExpression(expression) {
             with(expression) {
                 IrDelegatingConstructorCallImpl(
@@ -301,7 +300,7 @@ open class DefaultParameterInjector<TContext : CommonBackendContext>(
     }
 
     override fun visitConstructorCall(expression: IrConstructorCall): IrExpression {
-        expression.transformChildrenVoid()
+        expression.transformChildrenVoid(this)
         return visitFunctionAccessExpression(expression) {
             with(expression) {
                 IrConstructorCallImpl.fromSymbolOwner(
@@ -316,7 +315,7 @@ open class DefaultParameterInjector<TContext : CommonBackendContext>(
     }
 
     override fun visitEnumConstructorCall(expression: IrEnumConstructorCall): IrExpression {
-        expression.transformChildrenVoid()
+        expression.transformChildrenVoid(this)
         return visitFunctionAccessExpression(expression) {
             with(expression) {
                 IrEnumConstructorCallImpl(
@@ -328,7 +327,7 @@ open class DefaultParameterInjector<TContext : CommonBackendContext>(
     }
 
     override fun visitCall(expression: IrCall): IrExpression {
-        expression.transformChildrenVoid()
+        expression.transformChildrenVoid(this)
         val declaration = expression.symbol.owner
         val typeParametersToRemove = if (needsTypeArgumentOffset(declaration)) declaration.parentAsClass.typeParameters.size else 0
         with(expression) {

compiler/ir/backend.common/src/org/jetbrains/kotlin/backend/common/lower/DelegatedPropertyOptimizationLowering.kt

@@ -25,7 +25,6 @@ import org.jetbrains.kotlin.ir.expressions.impl.IrGetFieldImpl
 import org.jetbrains.kotlin.ir.symbols.IrSymbol
 import org.jetbrains.kotlin.ir.util.setDeclarationsParent
 import org.jetbrains.kotlin.ir.visitors.IrElementTransformerVoid
-import org.jetbrains.kotlin.ir.visitors.transformChildrenVoid
 
 private val KPROPERTIES_FOR_DELEGATION by IrDeclarationOriginImpl.Regular
 

compiler/ir/backend.common/src/org/jetbrains/kotlin/backend/common/lower/EnumWhenLowering.kt

@@ -39,7 +39,7 @@ open class EnumWhenLowering(protected open val context: CommonBackendContext) :
     }
 
     override fun visitBlock(expression: IrBlock): IrExpression {
-        expression.transformChildrenVoid()
+        expression.transformChildrenVoid(this)
 
         // NB: See BranchingExpressionGenerator to get insight about `when` block translation to IR.
         if (expression.origin != IrStatementOrigin.WHEN) {

compiler/ir/backend.common/src/org/jetbrains/kotlin/backend/common/lower/ExpectDeclarationRemover.kt

@@ -160,7 +160,7 @@ open class ExpectDeclarationRemover(val symbolTable: ReferenceSymbolTable, priva
             .deepCopyWithSymbols(actualFunction) { IrTypeParameterRemapper(expectActualTypeParametersMap) }
             .transform(object : IrElementTransformerVoid() {
                 override fun visitGetValue(expression: IrGetValue): IrExpression {
-                    expression.transformChildrenVoid()
+                    expression.transformChildrenVoid(this)
                     return expression.remapSymbolParent(
                         classRemapper = { symbolTable.descriptorExtension.referenceClass(it.descriptor.findActualForExpect() as ClassDescriptor).owner },
                         functionRemapper = { symbolTable.referenceFunction(it.descriptor.findActualForExpect() as FunctionDescriptor).owner }

compiler/ir/backend.common/src/org/jetbrains/kotlin/backend/common/lower/ExpressionBodyTransformer.kt

@@ -15,8 +15,6 @@ import org.jetbrains.kotlin.ir.declarations.createBlockBody
 import org.jetbrains.kotlin.ir.expressions.IrBlockBody
 import org.jetbrains.kotlin.ir.expressions.IrExpressionBody
 import org.jetbrains.kotlin.ir.visitors.IrVisitorVoid
-import org.jetbrains.kotlin.ir.visitors.acceptChildrenVoid
-import org.jetbrains.kotlin.ir.visitors.acceptVoid
 
 /**
  * Replaces [IrExpressionBody] with [IrBlockBody] returning this expression.

compiler/ir/backend.common/src/org/jetbrains/kotlin/backend/common/lower/FinallyBlocksLowering.kt

@@ -24,7 +24,6 @@ import org.jetbrains.kotlin.ir.types.IrType
 import org.jetbrains.kotlin.ir.types.isNothing
 import org.jetbrains.kotlin.ir.types.isUnit
 import org.jetbrains.kotlin.ir.util.deepCopyWithSymbols
-import org.jetbrains.kotlin.ir.visitors.transformChildrenVoid
 import org.jetbrains.kotlin.name.Name
 
 val FINALLY_EXPRESSION by IrStatementOriginImpl

compiler/ir/backend.common/src/org/jetbrains/kotlin/backend/common/lower/FlattenStringConcatenationLowering.kt

@@ -21,8 +21,6 @@ import org.jetbrains.kotlin.ir.util.isTopLevelInPackage
 import org.jetbrains.kotlin.ir.util.isUnsigned
 import org.jetbrains.kotlin.ir.visitors.IrElementTransformerVoid
 import org.jetbrains.kotlin.ir.visitors.IrVisitorVoid
-import org.jetbrains.kotlin.ir.visitors.acceptChildrenVoid
-import org.jetbrains.kotlin.ir.visitors.transformChildrenVoid
 import org.jetbrains.kotlin.util.OperatorNameConventions
 import kotlin.math.max
 import kotlin.math.min

compiler/ir/backend.common/src/org/jetbrains/kotlin/backend/common/lower/IfNullExpressionsFusionLowering.kt

@@ -20,7 +20,6 @@ import org.jetbrains.kotlin.ir.util.isNullable
 import org.jetbrains.kotlin.ir.util.isTrivial
 import org.jetbrains.kotlin.ir.util.shallowCopy
 import org.jetbrains.kotlin.ir.visitors.IrElementTransformerVoid
-import org.jetbrains.kotlin.ir.visitors.transformChildrenVoid
 
 /**
  * Simplifies `?.` and `?:` operator chains.

compiler/ir/backend.common/src/org/jetbrains/kotlin/backend/common/lower/InitializersLowering.kt

@@ -21,7 +21,6 @@ import org.jetbrains.kotlin.ir.util.deepCopyWithSymbols
 import org.jetbrains.kotlin.ir.util.render
 import org.jetbrains.kotlin.ir.visitors.IrElementTransformerVoid
 import org.jetbrains.kotlin.ir.visitors.IrVisitorVoid
-import org.jetbrains.kotlin.ir.visitors.transformChildrenVoid
 
 /**
  * Merges init block and field initializers into constructors.

compiler/ir/backend.common/src/org/jetbrains/kotlin/backend/common/lower/InlineClassDeclarationLowering.kt

@@ -21,7 +21,6 @@ import org.jetbrains.kotlin.ir.types.extractTypeParameters
 import org.jetbrains.kotlin.ir.types.impl.IrSimpleTypeImpl
 import org.jetbrains.kotlin.ir.util.*
 import org.jetbrains.kotlin.ir.visitors.IrElementTransformerVoid
-import org.jetbrains.kotlin.ir.visitors.transformChildrenVoid
 import org.jetbrains.kotlin.name.Name
 import org.jetbrains.kotlin.utils.addToStdlib.assignFrom
 import kotlin.collections.get
@@ -103,7 +102,7 @@ open class InlineClassDeclarationLowering(private val context: CommonBackendCont
                                 if (isMemberFieldSet) {
                                     setMemberField = expression.deepCopyWithSymbols(irConstructor)
                                 }
-                                expression.transformChildrenVoid()
+                                expression.transformChildrenVoid(this)
                                 if (isMemberFieldSet) {
                                     return builder.irBlock {
                                         if (!expression.value.isPure(true)) {
@@ -119,14 +118,14 @@ open class InlineClassDeclarationLowering(private val context: CommonBackendCont
                             }
 
                             override fun visitGetField(expression: IrGetField): IrExpression {
-                                expression.transformChildrenVoid()
+                                expression.transformChildrenVoid(this)
                                 if (expression.symbol.owner.parent == klass)
                                     return builder.irGet(initFunction.parameters.single())
                                 return expression
                             }
 
                             override fun visitGetValue(expression: IrGetValue): IrExpression {
-                                expression.transformChildrenVoid()
+                                expression.transformChildrenVoid(this)
                                 if (expression.symbol.owner.parent == klass)
                                     return unboxedInlineClassValue()
                                 if (expression.symbol == origParameterSymbol)
@@ -135,7 +134,7 @@ open class InlineClassDeclarationLowering(private val context: CommonBackendCont
                             }
 
                             override fun visitSetValue(expression: IrSetValue): IrExpression {
-                                expression.transformChildrenVoid()
+                                expression.transformChildrenVoid(this)
                                 if (expression.symbol == origParameterSymbol)
                                     return builder.irSet(initFunction.parameters.single(), expression.value)
                                 return expression
@@ -177,7 +176,7 @@ open class InlineClassDeclarationLowering(private val context: CommonBackendCont
                     (constructorBody as IrBlockBody).statements.forEach { statement ->
                         +statement.transformStatement(object : IrElementTransformerVoid() {
                             override fun visitDelegatingConstructorCall(expression: IrDelegatingConstructorCall): IrExpression {
-                                expression.transformChildrenVoid()
+                                expression.transformChildrenVoid(this)
                                 // Static function for delegating constructors return unboxed instance of inline class
                                 expression.type = irClass.defaultType
                                 return irBlock(expression) {
@@ -190,7 +189,7 @@ open class InlineClassDeclarationLowering(private val context: CommonBackendCont
                             }
 
                             override fun visitGetValue(expression: IrGetValue): IrExpression {
-                                expression.transformChildrenVoid()
+                                expression.transformChildrenVoid(this)
                                 if (expression.symbol == irClass.thisReceiver?.symbol) {
                                     return irGet(thisVar)
                                 }
@@ -200,7 +199,7 @@ open class InlineClassDeclarationLowering(private val context: CommonBackendCont
                             }
 
                             override fun visitSetValue(expression: IrSetValue): IrExpression {
-                                expression.transformChildrenVoid()
+                                expression.transformChildrenVoid(this)
                                 parameterMapping[expression.symbol]?.let { return irSet(it.symbol, expression.value) }
                                 return expression
                             }
@@ -213,7 +212,7 @@ open class InlineClassDeclarationLowering(private val context: CommonBackendCont
                             }
 
                             override fun visitReturn(expression: IrReturn): IrExpression {
-                                expression.transformChildrenVoid()
+                                expression.transformChildrenVoid(this)
                                 if (expression.returnTargetSymbol == irConstructor.symbol) {
                                     return irReturn(irBlock(expression.startOffset, expression.endOffset) {
                                         +expression.value
@@ -264,7 +263,7 @@ open class InlineClassDeclarationLowering(private val context: CommonBackendCont
 
                     override fun visitSetValue(expression: IrSetValue): IrExpression {
                         val valueDeclaration = expression.symbol.owner as? IrValueParameter ?: return super.visitSetValue(expression)
-                        expression.transformChildrenVoid()
+                        expression.transformChildrenVoid(this)
                         return context.createIrBuilder(staticMethod.symbol).irSet(
                             when (valueDeclaration) {
                                 in function.parameters -> staticMethod.parameters[valueDeclaration.indexInParameters].symbol

compiler/ir/backend.common/src/org/jetbrains/kotlin/backend/common/lower/InnerClassesLowering.kt

@@ -24,7 +24,6 @@ import org.jetbrains.kotlin.ir.util.isLocal
 import org.jetbrains.kotlin.ir.util.parentAsClass
 import org.jetbrains.kotlin.ir.util.patchDeclarationParents
 import org.jetbrains.kotlin.ir.visitors.IrElementTransformerVoid
-import org.jetbrains.kotlin.ir.visitors.transformChildrenVoid
 import org.jetbrains.kotlin.utils.addToStdlib.assignFrom
 
 interface InnerClassesSupport {

compiler/ir/backend.common/src/org/jetbrains/kotlin/backend/common/lower/KlibAssertionLowering.kt

@@ -25,7 +25,6 @@ import org.jetbrains.kotlin.ir.symbols.IrSimpleFunctionSymbol
 import org.jetbrains.kotlin.ir.symbols.IrSymbol
 import org.jetbrains.kotlin.ir.visitors.IrElementTransformerVoid
 import org.jetbrains.kotlin.ir.visitors.IrTransformer
-import org.jetbrains.kotlin.ir.visitors.transformChildrenVoid
 
 /**
  * Transforms `assert(...) {...}` call into

compiler/ir/backend.common/src/org/jetbrains/kotlin/backend/common/lower/KotlinNothingValueExceptionLowering.kt

@@ -17,7 +17,6 @@ import org.jetbrains.kotlin.ir.expressions.IrExpression
 import org.jetbrains.kotlin.ir.symbols.IrSymbol
 import org.jetbrains.kotlin.ir.types.isNothing
 import org.jetbrains.kotlin.ir.visitors.IrElementTransformerVoid
-import org.jetbrains.kotlin.ir.visitors.transformChildrenVoid
 
 /**
  * Throws a proper exception for calls returning value of type [Nothing].