Revert "Remove second parameter incorrect nullable" #1736
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #1728
I made a mistake when accepted these changes. I checked what reflection returns and what is in the PHP source code. It turns out that $array is indeed an optional parameter and it's default value is null.
<?php
namespace B;
use ReflectionFunction;
$reflection = new ReflectionFunction('implode');
$parameters = $reflection->getParameters();
foreach ($parameters as $param) {
echo "Parameter: " . $param->getName();
echo "\nRequired: " . ($param->isOptional() ? "No" : "Yes");
echo "\n\n";
}
Output:
Parameter: separator
Required: Yes
Parameter: array
Required: No