Skip to content

Revert "Remove second parameter incorrect nullable" #1736

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 22, 2025
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions standard/standard_1.php
Original file line number Diff line number Diff line change
Expand Up @@ -1008,14 +1008,14 @@ function explode(string $separator, string $string, int $limit = PHP_INT_MAX) {}
* implode as glue would be
* the second parameter and thus, the bad prototype would be used.
* </p>
* @param array $array <p>
* @param array|null $array <p>
* The array of strings to implode.
* </p>
* @return string a string containing a string representation of all the array
* elements in the same order, with the glue string between each element.
*/
#[Pure]
function implode(array|string $separator = "", array $array): string {}
function implode(array|string $separator = "", ?array $array): string {}

/**
* Alias:
Expand All @@ -1026,14 +1026,14 @@ function implode(array|string $separator = "", array $array): string {}
* implode as glue would be
* the second parameter and thus, the bad prototype would be used.
* </p>
* @param array $array <p>
* @param array|null $array <p>
* The array of strings to implode.
* </p>
* @return string a string containing a string representation of all the array
* elements in the same order, with the glue string between each element.
*/
#[Pure]
function join(array|string $separator = "", array $array): string {}
function join(array|string $separator = "", ?array $array): string {}

/**
* Set locale information
Expand Down
Loading