Part 2 Extension functions non-allocate intermediate objects #1140
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
@MatkovIvan @igordmn would be nice to have it before Xmas holidays :) |
Collaborator
|
@ApoloApps, we can review it only in ~3 weeks Happy holidays! |
ApoloApps
commented
Dec 29, 2025
Collaborator
|
Ignore the CI failures, we currently have issues running external PRs. |
igordmn
requested changes
Jan 12, 2026
skiko/src/commonMain/kotlin/org/jetbrains/skia/skottie/Animation.kt
Outdated
Show resolved
Hide resolved
…se the destructured function overloads (clipRRect, make*)
…s the removal of the deprecation annotations and the revert of the modified associated tests
igordmn
approved these changes
Jan 28, 2026
Collaborator
|
Thank you! Merged |
MatkovIvan
added a commit
to JetBrains/compose-multiplatform-core
that referenced
this pull request
Jan 29, 2026
Fixes [CMP-9705](https://youtrack.jetbrains.com/issue/CMP-9705) Update skiko to 0.9.43 ## What's Changed in `skiko` - JetBrains/skiko#1149 - JetBrains/skiko#1140 - JetBrains/skiko#1052 **Full Changelog**: http://github.com/JetBrains/skiko/compare/v0.9.41...v0.9.43 (no customer-facing issues/notes from Compose POV) ## Release Notes N/A
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is part 2 of this pr
What has changed?
Next
Try (important keyword here :), cause if not wrong there are Skia and Compose diffs on how they're treated) doing less copies of Matrix
Release Notes
Added API that can accept primitive values instead of
Rect,RRect,Offsetto avoid additional object allocation