Skip to content

Conversation

@IbrahimAdelDev
Copy link

add port/eng.txt for define my university.

add port/eng.txt for define my university.
Copilot AI review requested due to automatic review settings February 1, 2026 20:35
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This pull request adds a new domain definition file for Port Said University's engineering subdomain (eng.psu.edu.eg) to enable students and teachers from this institution to request free JetBrains licenses.

Changes:

  • Added lib/domains/eg/edu/psu/eng.txt file containing "Port Said University" on both lines

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment on lines +1 to +2
Port Said University
Port Said University No newline at end of file
Copy link

Copilot AI Feb 1, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This file represents the subdomain "eng.psu.edu.eg" which typically would be used for a specific faculty (Engineering). Based on similar patterns in the codebase (e.g., lib/domains/eg/edu/cu/eng1.txt contains "Faculty of Engineering, Cairo University"), this file should contain a more specific name like "Faculty of Engineering, Port Said University" or "Engineering Faculty, Port Said University" rather than just the general university name. The generic name "Port Said University" would be more appropriate for a main domain file at lib/domains/eg/edu/psu.txt.

Suggested change
Port Said University
Port Said University
Faculty of Engineering, Port Said University
Faculty of Engineering, Port Said University

Copilot uses AI. Check for mistakes.
@@ -0,0 +1,2 @@
Port Said University
Port Said University No newline at end of file
Copy link

Copilot AI Feb 1, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

According to the README.md (lines 56-57), having the university name duplicated on the second line is unnecessary. While the README states "nothing bad happens if you do it", the more common convention in this codebase is to have either a single name followed by an empty line, or to use the second line for an alternative name (e.g., English translation or another common name). Since both lines are identical, the second line should be removed or left empty.

Copilot uses AI. Check for mistakes.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant