Skip to content

add port/eng.txt for define my university. #36526

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
IbrahimAdelDev wants to merge 1 commit into from
+2 −0
Closed

add port/eng.txt for define my university. #36526

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions lib/domains/eg/edu/psu/eng.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
Port Said University
Port Said University
Comment on lines +1 to +2
Copy link

Copilot AI Feb 1, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This file represents the subdomain "eng.psu.edu.eg" which typically would be used for a specific faculty (Engineering). Based on similar patterns in the codebase (e.g., lib/domains/eg/edu/cu/eng1.txt contains "Faculty of Engineering, Cairo University"), this file should contain a more specific name like "Faculty of Engineering, Port Said University" or "Engineering Faculty, Port Said University" rather than just the general university name. The generic name "Port Said University" would be more appropriate for a main domain file at lib/domains/eg/edu/psu.txt.

Suggested change
Port Said University
Port Said University
Faculty of Engineering, Port Said University
Faculty of Engineering, Port Said University

Copilot uses AI. Check for mistakes.
Copy link

Copilot AI Feb 1, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

According to the README.md (lines 56-57), having the university name duplicated on the second line is unnecessary. While the README states "nothing bad happens if you do it", the more common convention in this codebase is to have either a single name followed by an empty line, or to use the second line for an alternative name (e.g., English translation or another common name). Since both lines are identical, the second line should be removed or left empty.

Copilot uses AI. Check for mistakes.
Loading