add port/eng.txt for define my university. #36526
Conversation
add port/eng.txt for define my university.
There was a problem hiding this comment.
Pull request overview
This pull request adds a new domain definition file for Port Said University's engineering subdomain (eng.psu.edu.eg) to enable students and teachers from this institution to request free JetBrains licenses.
Changes:
- Added lib/domains/eg/edu/psu/eng.txt file containing "Port Said University" on both lines
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| Port Said University | ||
| Port Said University No newline at end of file |
There was a problem hiding this comment.
This file represents the subdomain "eng.psu.edu.eg" which typically would be used for a specific faculty (Engineering). Based on similar patterns in the codebase (e.g., lib/domains/eg/edu/cu/eng1.txt contains "Faculty of Engineering, Cairo University"), this file should contain a more specific name like "Faculty of Engineering, Port Said University" or "Engineering Faculty, Port Said University" rather than just the general university name. The generic name "Port Said University" would be more appropriate for a main domain file at lib/domains/eg/edu/psu.txt.
| Port Said University | |
| Port Said University | |
| Faculty of Engineering, Port Said University | |
| Faculty of Engineering, Port Said University |
| @@ -0,0 +1,2 @@ | |||
| Port Said University | |||
| Port Said University No newline at end of file | |||
There was a problem hiding this comment.
According to the README.md (lines 56-57), having the university name duplicated on the second line is unnecessary. While the README states "nothing bad happens if you do it", the more common convention in this codebase is to have either a single name followed by an empty line, or to use the second line for an alternative name (e.g., English translation or another common name). Since both lines are identical, the second line should be removed or left empty.
|
@IbrahimAdelDev I am sorry, the domain eng.psu.edu.eg was removed from the trusted list due to past abuse. If you are a student, we recommend joining GitHub Education to get the GitHub Student Developer Pack. It includes a free JetBrains educational subscription, which you can claim via the GitHub tab at https://www.jetbrains.com/shop/eform/students. If you are a teacher, you can apply for a free JetBrains subscription by submitting official proof of employment. To apply, please use the Official document tab at https://www.jetbrains.com/shop/eform/students. We recommend students to apply with a GitHub account whenever possible. If using one is extremely inconvenient for you, your school's IT department may contact us at [email protected]. We can provide the IT department with technical information to help identify and fix the vulnerability that led to the abuse. The information may be shared only with authorized university representatives. If the IT department confirms the issue is fixed, we can reinstate the domain to the trusted list. In some cases, this process may take longer if the abuse was severe. |
2 participants
add port/eng.txt for define my university.