Extends launch-file package detection in find_launch_dependencies.py to cover additional launch_ros constructs, and better_launch#22
Merged
Conversation
…_index, better_launch - Unify Node-family regex (Node/LifecycleNode/ComposableNode/ComposableLifecycleNode) - Add FindPackagePrefix and - Add get_package_share_path / get_package_prefix - Add XML <composable_node> and <node_container> - Add better_launch bl.node / bl.include - Scoped .toml support: package = '...' only under launch/ dirs
|
|
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
launch_rospackage identifiers to the launch dependency scanner (composable nodes,FindPackagePrefix/find-pkg-prefix,get_package_share_path,get_package_prefix, etc.).better_launchlaunch files in Python (bl.node/bl.include).better_launchTOML launch files (only.tomlfiles under alaunch/directory contribute deps, to avoid false positives from project config TOMLs).