Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CompatHelper: bump compat for ForwardDiff to 1, (keep existing compat) #182

Merged

Conversation

github-actions[bot]
Copy link

This pull request changes the compat entry for the ForwardDiff package from 0.10 to 0.10, 1.
This keeps the compat entries for earlier versions.

Note: I have not tested your package with this new compat entry.
It is your responsibility to make sure that your package tests pass before you merge this pull request.

@baggepinnen baggepinnen force-pushed the compathelper/new_version/2025-03-27-01-26-14-513-00499460369 branch from 0ab4297 to ccacc75 Compare March 27, 2025 01:26
@franckgaga
Copy link
Member

franckgaga commented Mar 29, 2025

@baggepinnen I'm working on removing PreallocationTools dependancy. The only place that I still use it is in RungeKutta, but I can avoid it by passing the $\mathbf{k}_1$ to $\mathbf{k}_4$ vectors in arguments and fill them in-place. I'll finish this today probably. Afterward, the conflict above will be resolved.

edit: FYI, I will concatenate $\mathbf{k}_1$ to $\mathbf{k}_4$ in a single $\mathbf{k}$ vector. First, it is more agnostic of the ODE solver. Second, the signature of state update function is way shorter like that.

@franckgaga
Copy link
Member

franckgaga commented Mar 29, 2025

Ok the test pass without the force_latest_compatible_version=true option. This option is not used for normal PRs, only CompatHelper automated PRs. I tried to resolved the conflicts in the compat entries, and also understand why this option is forced, but I may be too dumb for this XD. I will merge the PR anyway since I'm pretty confident that this is not caused by the changed in ForwardDiff.jl, and all the tests should pass in a normal CI runs (they pass locally).

@franckgaga franckgaga merged commit 3705821 into main Mar 29, 2025
1 of 4 checks passed
@franckgaga franckgaga deleted the compathelper/new_version/2025-03-27-01-26-14-513-00499460369 branch March 29, 2025 20:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant