[RFC] Log a backtrace on entrance to type inference (option 2) #58124
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is needed to eliminate the `Core.Compiler.Timings` module while still keeping SnoopCompile working.
This was referenced Apr 15, 2025
|
I have a weak preference for this over option 1. |
|
I like this one better too. |
vtjnash
reviewed
Apr 15, 2025
| @@ -1432,6 +1438,7 @@ function typeinf_ext_toplevel(methods::Vector{Any}, worlds::Vector{UInt}, trim_m | |||
| inspected = IdSet{CodeInstance}() | |||
| tocompile = Vector{CodeInstance}() | |||
| codeinfos = [] | |||
| bt = collect_dispatch_backtrace[] ? backtrace() : nothing | |||
There was a problem hiding this comment.
This method is not actually relevant to dispatch, so these additional changes (just the first one) should not be included in this PR
vtjnash
reviewed
Apr 15, 2025
There was a problem hiding this comment.
I am neutral between these PR, as they seem to express entirely different operations (first-dispatch vs first-infer) which may occur at different times in different places. The one thing that must occur before merging though is adding a lock around them (c.f. jl_push_newly_inferred for possible inspiration, as it seems to be fairly common that we need a primitive "locked array push" similar to that)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is needed to eliminate the
Core.Compiler.Timingsmodule while still keeping SnoopCompile working.This is one mechanism to add a backtrace to each entrance to inference. An alternative approach is presented in #58123. Only one of these should be merged.