Skip to content

Fix followers/following tests#251

Open
arnavk23 wants to merge 3 commits into
JuliaWeb:masterfrom
arnavk23:fix-followers-tests
Open

Fix followers/following tests#251
arnavk23 wants to merge 3 commits into
JuliaWeb:masterfrom
arnavk23:fix-followers-tests

Conversation

@arnavk23
Copy link
Copy Markdown

@arnavk23 arnavk23 commented Jan 4, 2026

Testing

julia --project -e 'using Pkg; Pkg.test(; test_args=["read_only_api_tests"])' (passes with provided token; the suite still has the same pre-existing broken cases elsewhere).

@codecov
Copy link
Copy Markdown

codecov Bot commented Jan 4, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 58.65%. Comparing base (97e94e4) to head (e87d667).

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #251      +/-   ##
==========================================
+ Coverage   58.45%   58.65%   +0.20%     
==========================================
  Files          37       37              
  Lines         982      982              
==========================================
+ Hits          574      576       +2     
+ Misses        408      406       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@arnavk23
Copy link
Copy Markdown
Author

arnavk23 commented Jan 4, 2026

@DilumAluthge All tests pass. Please review this pr. Thanks!

@DilumAluthge DilumAluthge self-requested a review January 5, 2026 02:10
@DilumAluthge
Copy link
Copy Markdown
Member

Thanks for working on this one as well!

Regarding the changes on lines 108 through 120 (the changes around the check_membership() tests - could you move those changes out into a separate pull request? Then we can keep this PR focused just on followers/following.

@arnavk23 arnavk23 closed this Jan 16, 2026
@arnavk23 arnavk23 reopened this Jan 16, 2026
@arnavk23 arnavk23 changed the title Fix followers/following tests and guard org membership when unauthorized Fix followers/following tests Jan 16, 2026
@arnavk23
Copy link
Copy Markdown
Author

Thanks for working on this one as well!

@DilumAluthge done as suggested.

@DilumAluthge
Copy link
Copy Markdown
Member

I think we might add some utility functionality in #252 that we can then use in this PR. So it might make sense for us to try to finish up #252 first - then we don't have to duplicate our work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

TODO: Fix tests for GitHub.followers and GitHub.following

2 participants