Skip to content

Fix followers/following tests #251

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
arnavk23 wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Fix followers/following tests #251

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
a087ee7
Fix followers/following tests and guard org membership when unauthorized
arnavk23 Jan 4, 2026
3dc2348
Revert membership test changes to focus PR on followers/following
arnavk23 Jan 16, 2026
e87d667
Merge branch 'master' into fix-followers-tests
arnavk23 Jan 18, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 18 additions & 3 deletions test/read_only_api_tests.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,7 +68,9 @@ testuser = Owner(testsuite_username)

@testset "Owners" begin
# test GitHub.owner
@test name(owner(testuser; auth = auth)) == name(testuser)
testuser_profile = owner(testuser; auth = auth)

@test name(testuser_profile) == name(testuser)
@test name(owner(julweb; auth = auth)) == name(julweb)

# test GitHub.orgs
Expand All @@ -77,8 +79,21 @@ testuser = Owner(testsuite_username)
@test length(members) > 1

# test GitHub.followers, GitHub.following
@test_skip hasghobj("jrevels", first(followers(testuser; auth = auth))) # TODO FIXME: Fix these tests. https://github.com/JuliaWeb/GitHub.jl/issues/236
@test_skip hasghobj("jrevels", first(following(testuser; auth = auth))) # TODO FIXME: Fix these tests. https://github.com/JuliaWeb/GitHub.jl/issues/236
followers_list, followers_page = followers(testuser; auth = auth)
@test followers_list isa Vector{Owner}
@test followers_page isa Dict
@test all(x -> x isa Owner, followers_list)
if testuser_profile.followers !== nothing
@test length(followers_list) == testuser_profile.followers
end

following_list, following_page = following(testuser; auth = auth)
@test following_list isa Vector{Owner}
@test following_page isa Dict
@test all(x -> x isa Owner, following_list)
if testuser_profile.following !== nothing
@test length(following_list) == testuser_profile.following
end

# test GitHub.repos
@test hasghobj(ghjl, first(repos(julweb; auth = auth)))
Expand Down