Skip to content

Add tests for starred/watchers/watched activity APIs#252

Open
arnavk23 wants to merge 7 commits into
JuliaWeb:masterfrom
arnavk23:fix-issue-237-clean
Open

Add tests for starred/watchers/watched activity APIs#252
arnavk23 wants to merge 7 commits into
JuliaWeb:masterfrom
arnavk23:fix-issue-237-clean

Conversation

@arnavk23
Copy link
Copy Markdown

@arnavk23 arnavk23 commented Jan 4, 2026

  • Added robust activity coverage for stargazers, starred, watchers, and watched: type checks, non-empty stargazers, count check against subscribers_count when available, and safe handling for users with zero starred/watched repos read_only_api_tests.jl:209-238.
  • Tests: Pkg.test(; test_args=["read_only_api_tests"]) passes with your token (only the pre-existing broken case remains).
  • Fixes TODO: Fix tests for starred, watchers, and watched #237

@codecov
Copy link
Copy Markdown

codecov Bot commented Jan 4, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 58.96%. Comparing base (97e94e4) to head (a88991c).

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #252      +/-   ##
==========================================
+ Coverage   58.45%   58.96%   +0.50%     
==========================================
  Files          37       37              
  Lines         982      982              
==========================================
+ Hits          574      579       +5     
+ Misses        408      403       -5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@arnavk23
Copy link
Copy Markdown
Author

arnavk23 commented Jan 4, 2026

@DilumAluthge All tests pass. Please review this pr. Thanks!

@DilumAluthge DilumAluthge self-requested a review January 5, 2026 02:11
Copy link
Copy Markdown
Member

@DilumAluthge DilumAluthge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for working on this!

I've left a few minor comments. Let me know if you have any questions.

Comment thread test/read_only_api_tests.jl Outdated
Comment thread test/read_only_api_tests.jl
Comment thread test/read_only_api_tests.jl
Comment thread test/read_only_api_tests.jl Outdated
Comment thread test/read_only_api_tests.jl
Comment thread test/read_only_api_tests.jl
@DilumAluthge DilumAluthge changed the title Add coverage for starred/watchers/watched activity APIs Add tests for starred/watchers/watched activity APIs Jan 16, 2026
@arnavk23 arnavk23 force-pushed the fix-issue-237-clean branch from d704568 to 949f6be Compare January 16, 2026 19:36
@arnavk23 arnavk23 requested a review from DilumAluthge January 16, 2026 19:42
Comment thread test/read_only_api_tests.jl Outdated
@arnavk23 arnavk23 requested a review from DilumAluthge January 17, 2026 09:02
@arnavk23
Copy link
Copy Markdown
Author

@DilumAluthge please review this pr again. Thanks!

@DilumAluthge
Copy link
Copy Markdown
Member

Thanks for the bump! I've added this to my queue to review, but I might not get to it immediately.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

TODO: Fix tests for starred, watchers, and watched

2 participants