Skip to content

Silence unused returned value warning#106

Open
mkrus wants to merge 1 commit into
mainfrom
wip_fix_macos
Open

Silence unused returned value warning#106
mkrus wants to merge 1 commit into
mainfrom
wip_fix_macos

Conversation

@mkrus

@mkrus mkrus commented Dec 15, 2025

Copy link
Copy Markdown
Member

No description provided.

Change-Id: If714fb1b10d7323e1662b30d4a6c534401ca1aa3
@mkrus
mkrus requested a review from MiKom December 15, 2025 16:11
@MiKom

MiKom commented Dec 15, 2025

Copy link
Copy Markdown

In other places we use:

#include <utility>

//...

std::ignore = //... stuff that returns value you want to ignore

which is more descriptive than the (void) idiom. Maybe let's be consistent with that?

@MiKom

MiKom commented Dec 17, 2025

Copy link
Copy Markdown

@copilot Can you try doing the changes I requested in a comment?

Copilot AI commented Dec 17, 2025

Copy link
Copy Markdown

@MiKom I've opened a new pull request, #107, to work on those changes. Once the pull request is ready, I'll request review from you.

@MiKom

MiKom commented Dec 17, 2025

Copy link
Copy Markdown

Bleh, copilot went off rails and did a different thing :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants