Replace KD_UNUSED macro with [[maybe_unused]] attribute#107
Draft
Copilot wants to merge 3 commits intowip_fix_macosfrom
Draft
Replace KD_UNUSED macro with [[maybe_unused]] attribute#107Copilot wants to merge 3 commits intowip_fix_macosfrom
Copilot wants to merge 3 commits intowip_fix_macosfrom
Conversation
Co-authored-by: MiKom <104767+MiKom@users.noreply.github.com>
Co-authored-by: MiKom <104767+MiKom@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix unused returned value warning by using std::ignore
Replace KD_UNUSED macro with [[maybe_unused]] attribute
Dec 17, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace custom
KD_UNUSEDmacro with C++17 standard[[maybe_unused]]attribute to align with existing codebase style inmosquitto_wrapper.h.Changes
Function parameters: Applied
[[maybe_unused]]directly to parameter declarations in function signatureswindow.cpp: Event handlers (mouse/keyboard events)linux_xcb_platform_integration.cpp:dumpScreenInfo()Local variables: Moved attribute to variable declaration instead of separate statement
linux_xcb_platform_event_loop.cpp: Event pointers in XCB event handlersExample
💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.