Downstream 1.3.302 #36
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There are more places to do this but that's a minimal change for the current task
This creates a buffer bound to the host visible coherent memory type. All implementations should support this according to the specification.
This needs shader instrumentation support - similar to descriptors
This test should trigger an error during QueueSubmit when the issue is fixed.
They are never used through their base class, so might as well remove the added complexity
Without going through an intricate dance with git to change the remote URL of a repository, it's simplest to just nuke the cloned folder, as we have to do a clean clone anyway.
The documentation states that users can override where to take a dependency from via variables like VULKAN_HEADERS_INSTALL_DIR, however the helper.cmake written by the scripts/CMakeLists.txt FORCE updates the cache variable to the location inside known_good.json, practically overwriting the user-provided path given on the CLI using -D, also going into the cache.
This removes ValidatorState ownership transfer helper. It was mostly additional abstraction layer that copied local variables and the result was stored as another local variable. Also replaced VUID-vkQueueSubmit-pSubmits-04626 with unassigned VUID when resource is EXCLUSIVE. 04626 is only about checking CONCURRENT resource properties. It also checks resource itself but not a barrier properties which is needed in unassigned VUID.
Based on Tobias's second comment here: https://gitlab.khronos.org/vulkan/vulkan/-/merge_requests/ 5799#note_403058
Remove the need for a staging std::vector
Previously, there were top level ValidationObjects stored in layer_data_map. These didn't do validation but contained more ValidationObjects in the object_dispatch vector (and a few others). This caused much confusion, since some members were only used at the top level and others only at the lower level. When uses got mixed up, this could only be detected at runtime since the members were always available even though they might not be set up correctly. Start to split this up by moving top level functionality to a new DispatchObject class. This does handle wrapping and coordination of validation by the child ValidationObjects. There are still many members related to settings, extension status, logging and dispatch tables that are duplicated at both levels. Fixing this is a big change that needs to be done separately. Also note that DispatchObject and ValidationObject are still used to represent both VkDevice and VkInstance. This will require much more work to undo.
While browsing/modifying this JSON file I spotted a glaring typo in the main layer description, and ended up fixing a few more in the settings descriptions down below.
|
|
MathiasMagnus
force-pushed
the
downstream-1.3.302
branch
2 times, most recently
from
6966d4b to
16be034
Compare
MathiasMagnus
force-pushed
the
downstream-1.3.302
branch
from
16be034 to
cce243b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Vulkan-ValidationLayers-downstream-1.3.302.patch