Skip to content

fix(bazel): repair v8-canary config (llvm flag target + lockfile drift) #625

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
KooshaPari wants to merge 27 commits into from
Closed

fix(bazel): repair v8-canary config (llvm flag target + lockfile drift) #625

Changes from 1 commit
Commits
Show all changes
27 commits
Select commit Hold shift + click to select a range
00cda4a
fix(bazel): point llvm flag at toolchains_llvm_bootstrapped, stop MOD…
KooshaPari Aug 9, 2026
1ff45b1
fix(bazel): point v8 platform flags at toolchains_llvm_bootstrapped
KooshaPari Aug 9, 2026
f989d12
fix(ci): restore v8 module wiring and fix repo-map labels
KooshaPari Aug 9, 2026
b486edd
fix(ci): add missing bazel_skylib dep for v8 package
KooshaPari Aug 9, 2026
819d02d
fix(ci): rename remaining stale @llvm labels to toolchains_llvm_boots…
KooshaPari Aug 9, 2026
4801504
fix(ci): define _GNU_SOURCE for custom libc++ builds
KooshaPari Aug 9, 2026
967ca1f
fix(ci): give v8 targets the hermetic C library headers
KooshaPari Aug 9, 2026
1a2c9b7
fix(ci): use canonical labels for v8 C-header select keys
KooshaPari Aug 9, 2026
b3f194c
fix(ci): expose hermetic C library headers via root-repo wrapper
KooshaPari Aug 9, 2026
6b916a9
fix(ci): wire C library headers into ICU custom-libcxx deps
KooshaPari Aug 9, 2026
ff34e24
fix(ci): order C library headers before libc++ in linux toolchain
KooshaPari Aug 9, 2026
05e7fda
Revert "fix(ci): order C library headers before libc++ in linux toolc…
KooshaPari Aug 9, 2026
7b7f331
fix(ci): let custom libc++ include_next chains reach the C library
KooshaPari Aug 9, 2026
9a5fa56
fix(ci): restructure custom libc++ wrappers to include_next first
KooshaPari Aug 9, 2026
d6a8e7d
fix(ci): stop linking the toolchain's libc++ into the custom-libc++ b…
KooshaPari Aug 9, 2026
e08947d
fix(ci): gate toolchain runtime suppression on user targets
KooshaPari Aug 9, 2026
0af1b1a
fix(ci): make the custom-libcxx config settings public
KooshaPari Aug 10, 2026
fbbc39c
fix(ci): expose runtime_stage to the main repo config_setting
KooshaPari Aug 10, 2026
bbd7caf
fix(ci): compile external C++ deps against the custom libc++
KooshaPari Aug 10, 2026
8921419
wip: capture 2026-08-02 helios-cli live eval changes (autocrlf bypass)
KooshaPari Aug 10, 2026
2e88ead
fix(ci): add codex-v8-poc to the cargo workspace
KooshaPari Aug 10, 2026
706535a
Merge branch 'main' into fix/v8-canary-bazel-2026-08-08
KooshaPari Aug 10, 2026
95c8076
fix(ci): exclude upstream rusty_v8 checkout from clean-worktree gate
KooshaPari Aug 11, 2026
eeaab31
wip: capture 2026-08-02 helios-cli live eval changes (autocrlf bypass)
KooshaPari Aug 12, 2026
a0f54ba
fix(ci): migrate .trunk/trunk.yaml to the 0.1 schema
KooshaPari Aug 12, 2026
0b86636
fix(ci): pin trunk linter versions in lint.enabled
KooshaPari Aug 12, 2026
cc4b919
fix(ci): bump trunk plugin ref to v1.11.0
KooshaPari Aug 12, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 9 additions & 1 deletion .bazelrc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,15 @@ common --enable_platform_specific_config
common:linux --host_platform=//:local_linux
common:windows --host_platform=//:local_windows
common --@rules_cc//cc/toolchains/args/archiver_flags:use_libtool_on_macos=False
common --@llvm//config:experimental_stub_libgcc_s
# The hermetic LLVM toolchain module is imported as toolchains_llvm_bootstrapped
# (see MODULE.bazel); the upstream @llvm name no longer exists in the repo map.
common --@toolchains_llvm_bootstrapped//config:experimental_stub_libgcc_s

# Bazelisk picks the latest Bazel (no .bazelversion), and the resolved module
# graph (rules_cc 0.2.16 vs 0.2.17) differs between runs; both rewrite the
# committed MODULE.bazel.lock and trip check-clean-worktree. Ignore the lockfile
# for builds; the repository cache keeps module resolution cheap.
build --lockfile_mode=off

@codeant-ai codeant-ai Bot Aug 9, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggestion: Disabling the Bzlmod lockfile for every build and test invocation allows Bazel to resolve a different module graph than the committed MODULE.bazel.lock, so builds can silently consume changed dependency or toolchain versions and no longer satisfy the repository's documented reproducibility invariant. Keep the lockfile enforced for normal builds and restrict any lockfile bypass to the dedicated lock-update workflow or an explicit developer option. [possible bug]

Severity Level: Major ⚠️ 
- ⚠️ V8 canary builds may use differing dependency graphs.
- ⚠️ Ordinary Bazel builds ignore committed dependency resolution.
- ⚠️ Local and CI results can diverge after registry changes.

Fix in Cursor Fix in VSCode Claude

(Use Cmd/Ctrl + Click for best experience)

Prompt for AI Agent 🤖 
This is a comment left during a code review.

**Path:** .bazelrc
**Line:** 29:29
**Comment:**
	*Possible Bug: Disabling the Bzlmod lockfile for every build and test invocation allows Bazel to resolve a different module graph than the committed `MODULE.bazel.lock`, so builds can silently consume changed dependency or toolchain versions and no longer satisfy the repository's documented reproducibility invariant. Keep the lockfile enforced for normal builds and restrict any lockfile bypass to the dedicated lock-update workflow or an explicit developer option.

Validate the correctness of the flagged issue. If correct, How can I resolve this? If you propose a fix, implement it and please make it concise.
Once fix is implemented, also check other comments on the same PR, and ask user if the user wants to fix the rest of the comments as well. if said yes, then fetch all the comments validate the correctness and implement a minimal fix
👍 | 👎


# TODO(zbarsky): rules_rust doesn't implement this flag properly with remote exec...
# common --@rules_rust//rust/settings:pipelined_compilation
Expand Down
Loading