Fix aut group knowl#6962
Merged
roed314 merged 2 commits intoLMFDB:mainfrom Apr 11, 2026
Merged
Conversation
roed314
reviewed
Apr 11, 2026
| unknown.remove('nilpotent') | ||
| unknown.remove('solvable') | ||
| unknown.remove('supersolvable') | ||
| unknown=list(set(unknown)-{'nilpotent','solvable','supersolvable'}) |
Member
There was a problem hiding this comment.
This doesn't preserve the order. I think better would be
for col in ['nilpotent', 'solvable', 'supersolvable']:
if col in unknown:
unknown.remove(col)
Member
Author
|
I wondered after submitting that maybe order mattered, so changed it so that the order is preserved. |
Member
|
Looks good! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix issue #6960
Open the knowl for the automorphism group
http://beta.lmfdb.org/Groups/Abstract/512.25
http://127.0.0.1:37777/Groups/Abstract/512.25