Skip to content

Fix aut group knowl #6962

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
roed314 merged 2 commits into from
Apr 11, 2026
+1 −3
Merged

Fix aut group knowl #6962

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3de6e59
Fix aut group knowl
jwj61 Apr 8, 2026
0a12372
Keep order in unknown
jwj61 Apr 11, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 1 addition & 3 deletions lmfdb/groups/abstract/main.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -738,9 +738,7 @@ def create_boolean_aut_string(gp, prefix="aut_", type="normal", name="automorphi
unknown.remove('nonsolvable')
prop = 'pgroup' # if p-group, we know it is nilpotent, solvable, and supersolvable
if getattr(gp,prefix+prop,None) > 1:
unknown.remove('nilpotent')
unknown.remove('solvable')
unknown.remove('supersolvable')
unknown=list(set(unknown)-{'nilpotent','solvable','supersolvable'})
Copy link
Copy Markdown
Member

@roed314 roed314 Apr 11, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This doesn't preserve the order. I think better would be

for col in ['nilpotent', 'solvable', 'supersolvable']:
    if col in unknown:
        unknown.remove(col)


unknown = [overall_display[prop] for prop in unknown]
if unknown and type != "knowl":
Expand Down
Loading