use enum for user class #438
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gierens
requested changes
Sep 9, 2025
There was a problem hiding this comment.
Good in general, thanks! ... What could be improved is mainly three-fold:
- The random user class generation for tests should stay as is and not be hard-coded.
- UserClass so far has had a variant 0 = NA (not available).
- I'm not a fan of panicking when not able to parse an integer. Either this should be handled explicitly using TryFrom or mapping to variant NA.
gierens
reviewed
Sep 9, 2025
gierens
requested changes
Sep 9, 2025
fredberto
force-pushed
the
user-class-enum
branch
2 times, most recently
from
5315882 to
9997ad7
Compare
fredberto
force-pushed
the
user-class-enum
branch
from
9997ad7 to
e691e78
Compare
gierens
added
enhancement
gierens
previously approved these changes
Sep 19, 2025
|
Just fixed a tiny detail ... moved UserClass to the submodule project since it is actually a property of a project rather than a user ... i know the name is a bit confusing. |
Signed-off-by: Sandro-Alessio Gierens <[email protected]>
gierens
force-pushed
the
user-class-enum
branch
from
d3aff6a to
e8522c1
Compare
gierens
approved these changes
Sep 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
close #425