add a wiping skill#8
Closed
chsahit wants to merge 6 commits into
Closed
Conversation
NishanthJKumar
left a comment
NishanthJKumar
left a comment
Member
There was a problem hiding this comment.
Great progress - this is looking quite good! left some minor comments. after check passes and comments are addressed, we can merge
| @@ -0,0 +1,157 @@ | |||
| """Interface for spot sweeping skill.""" | |||
Member
There was a problem hiding this comment.
nit: change to "wiping skill."
| @@ -0,0 +1,696 @@ | |||
| import argparse | |||
Member
There was a problem hiding this comment.
can we combine this with the previous file? two separate files seems a bit messy/redundant
| assert "OPENAI_API_KEY" in os.environ | ||
| key = os.environ["OPENAI_API_KEY"] | ||
|
|
||
| # @retry(wait=wait_random_exponential(min=1, max=60), |
Member
There was a problem hiding this comment.
if this is unnec, let's delete
| self.call_openai_api(messages, model=self.model_name, max_tokens=self._max_tokens, temperature=temperature) | ||
| for _ in range(num_completions) | ||
| ] | ||
| # while any("sorry" in response.lower() for response in responses): |
Member
There was a problem hiding this comment.
let's delete this as well if unnec
Member
|
superseded by #9 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.