Skip to content

Update validators - #44

Merged
agrojean-ledger merged 9 commits into
developfrom
update-validators
Jul 15, 2026
Merged

agrojean-ledger merged 9 commits into
developfrom
update-validators

Conversation

@agrojean-ledger

@agrojean-ledger agrojean-ledger commented Jul 9, 2026

Copy link
Copy Markdown
Collaborator

Validator party IDs updates

  • Updated the Kiln party IDs of validators for test net and dev net.

Display and transaction configuration:

  • Removed display configuration entries and field definitions related to proxy transfer operations in src/transaction/pb_node_display_config.c, effectively removing clear signing for Featured app proxy transactions. [1] [2]

Error message and assertion improvements:

  • App update process has been followed
  • Target branch is develop
  • Application version has been bumped

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates validator identity mappings and transaction display behavior, including removal of clear-signing support for Featured app proxy transfers, along with associated formatting/assertion-message cleanup and refreshed tests/snapshots.

Changes:

  • Updated validator participant ID mappings (testnet/devnet, and added mainnet dual-validator mapping support).
  • Removed proxy-transfer display configurations (disabling clear signing for Featured app proxy transactions) and updated UI snapshots accordingly.
  • Standardized/shortened several assertion messages and updated dev tooling/test helpers (pre-commit hooks, Python formatting).

Reviewed changes

Copilot reviewed 19 out of 253 changed files in this pull request and generated 3 comments.

Show a summary per file
File Description
vendor/nanopb/pb_decode.c Adjusts required-field tracking storage sizing and initialization.
tests/tx_examples/token_transfer_cip107.json Formatting-only change (EOF/newline).
tests/test_pubkey_cmd.py Minor formatting (blank line).
tests/snapshots/stax/test_sign_proxy_token_transfer_blind_signing_disabled/00003.png Updated snapshot for proxy-transfer signing flow.
tests/snapshots/stax/test_sign_proxy_token_transfer_blind_signing_disabled/00004.png Updated snapshot for proxy-transfer signing flow.
tests/snapshots/stax/test_sign_proxy_token_transfer_blind_signing_disabled_enable_bs/00000.png Updated snapshot for proxy-transfer signing flow (BS enabled).
tests/snapshots/stax/test_sign_proxy_token_transfer_blind_signing_disabled_enable_bs/00003.png Updated snapshot for proxy-transfer signing flow (BS enabled).
tests/snapshots/nanox/test_sign_proxy_token_transfer_blind_signing_disabled/00004.png Updated snapshot for proxy-transfer signing flow.
tests/snapshots/nanosp/test_sign_proxy_token_transfer_blind_signing_disabled/00004.png Updated snapshot for proxy-transfer signing flow.
tests/snapshots/flex/test_sign_proxy_token_transfer_blind_signing_disabled/00003.png Updated snapshot for proxy-transfer signing flow.
tests/snapshots/flex/test_sign_proxy_token_transfer_blind_signing_disabled/00004.png Updated snapshot for proxy-transfer signing flow.
tests/snapshots/flex/test_sign_proxy_token_transfer_blind_signing_disabled_enable_bs/00000.png Updated snapshot for proxy-transfer signing flow (BS enabled).
tests/snapshots/flex/test_sign_proxy_token_transfer_blind_signing_disabled_enable_bs/00003.png Updated snapshot for proxy-transfer signing flow (BS enabled).
tests/snapshots/apex_p/test_sign_proxy_token_transfer_blind_signing_disabled/00003.png Updated snapshot for proxy-transfer signing flow.
tests/snapshots/apex_p/test_sign_proxy_token_transfer_blind_signing_disabled/00004.png Updated snapshot for proxy-transfer signing flow.
tests/snapshots/apex_p/test_sign_proxy_token_transfer_blind_signing_disabled_enable_bs/00000.png Updated snapshot for proxy-transfer signing flow (BS enabled).
tests/snapshots/apex_p/test_sign_proxy_token_transfer_blind_signing_disabled_enable_bs/00003.png Updated snapshot for proxy-transfer signing flow (BS enabled).
tests/application_client/canton_transaction.py Test client formatting and small DER-prefix/style cleanups.
tests/application_client/canton_response_unpacker.py Reformats response unpacking signature/return for readability.
tests/application_client/canton_command_sender.py Reformats topology-signing helper; potential formatter compliance issue.
src/utils.c Standardizes assertion message text.
src/ui/menu_nbgl.c Pointer-style formatting and minor cast formatting.
src/types.h Pointer-style formatting.
src/transaction/untyped_versioned_msg.c Updates validator ID mappings and adds mainnet dual-validator config entry.
src/transaction/pb_parser.c Standardizes assertion message text.
src/transaction/pb_node_display_parser.c Minor cast/deref formatting cleanup.
src/transaction/pb_node_display_config.c Removes proxy-transfer display configs and tightens macro formatting.
src/transaction/pb_hashing_parser.c Standardizes assertion message text.
src/transaction/canonical_hash.c Standardizes assertion message text.
src/helper/send_reponse.c Standardizes assertion message text (one inconsistency remains).
src/handler/get_version.c Minor compound-literal formatting.
Makefile Bumps app version patch (3.3.2 → 3.3.3).
CHANGELOG.md Adds 3.3.3 entry describing validator/proxy-signing changes.
attestations/generateCryptoData.py Removes unused variable assignment for openssl command output.
.pre-commit-config.yaml Updates hook versions and adds ruff hooks (currently mis-indented).

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread .pre-commit-config.yaml
Comment thread src/helper/send_reponse.c
Comment thread tests/application_client/canton_command_sender.py
Comment thread vendor/nanopb/pb_decode.c
@agrojean-ledger
agrojean-ledger merged commit 85359b6 into develop Jul 15, 2026
77 checks passed
@agrojean-ledger
agrojean-ledger deleted the update-validators branch July 15, 2026 08:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants