Update validators - #44
Merged
Merged
Conversation
agrojean-ledger
force-pushed
the
update-validators
branch
from
July 10, 2026 13:14
5ce8357 to
f9749ec
Compare
agrojean-ledger
force-pushed
the
update-validators
branch
from
July 10, 2026 13:37
f9749ec to
7043d5c
Compare
There was a problem hiding this comment.
Pull request overview
Updates validator identity mappings and transaction display behavior, including removal of clear-signing support for Featured app proxy transfers, along with associated formatting/assertion-message cleanup and refreshed tests/snapshots.
Changes:
- Updated validator participant ID mappings (testnet/devnet, and added mainnet dual-validator mapping support).
- Removed proxy-transfer display configurations (disabling clear signing for Featured app proxy transactions) and updated UI snapshots accordingly.
- Standardized/shortened several assertion messages and updated dev tooling/test helpers (pre-commit hooks, Python formatting).
Reviewed changes
Copilot reviewed 19 out of 253 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| vendor/nanopb/pb_decode.c | Adjusts required-field tracking storage sizing and initialization. |
| tests/tx_examples/token_transfer_cip107.json | Formatting-only change (EOF/newline). |
| tests/test_pubkey_cmd.py | Minor formatting (blank line). |
| tests/snapshots/stax/test_sign_proxy_token_transfer_blind_signing_disabled/00003.png | Updated snapshot for proxy-transfer signing flow. |
| tests/snapshots/stax/test_sign_proxy_token_transfer_blind_signing_disabled/00004.png | Updated snapshot for proxy-transfer signing flow. |
| tests/snapshots/stax/test_sign_proxy_token_transfer_blind_signing_disabled_enable_bs/00000.png | Updated snapshot for proxy-transfer signing flow (BS enabled). |
| tests/snapshots/stax/test_sign_proxy_token_transfer_blind_signing_disabled_enable_bs/00003.png | Updated snapshot for proxy-transfer signing flow (BS enabled). |
| tests/snapshots/nanox/test_sign_proxy_token_transfer_blind_signing_disabled/00004.png | Updated snapshot for proxy-transfer signing flow. |
| tests/snapshots/nanosp/test_sign_proxy_token_transfer_blind_signing_disabled/00004.png | Updated snapshot for proxy-transfer signing flow. |
| tests/snapshots/flex/test_sign_proxy_token_transfer_blind_signing_disabled/00003.png | Updated snapshot for proxy-transfer signing flow. |
| tests/snapshots/flex/test_sign_proxy_token_transfer_blind_signing_disabled/00004.png | Updated snapshot for proxy-transfer signing flow. |
| tests/snapshots/flex/test_sign_proxy_token_transfer_blind_signing_disabled_enable_bs/00000.png | Updated snapshot for proxy-transfer signing flow (BS enabled). |
| tests/snapshots/flex/test_sign_proxy_token_transfer_blind_signing_disabled_enable_bs/00003.png | Updated snapshot for proxy-transfer signing flow (BS enabled). |
| tests/snapshots/apex_p/test_sign_proxy_token_transfer_blind_signing_disabled/00003.png | Updated snapshot for proxy-transfer signing flow. |
| tests/snapshots/apex_p/test_sign_proxy_token_transfer_blind_signing_disabled/00004.png | Updated snapshot for proxy-transfer signing flow. |
| tests/snapshots/apex_p/test_sign_proxy_token_transfer_blind_signing_disabled_enable_bs/00000.png | Updated snapshot for proxy-transfer signing flow (BS enabled). |
| tests/snapshots/apex_p/test_sign_proxy_token_transfer_blind_signing_disabled_enable_bs/00003.png | Updated snapshot for proxy-transfer signing flow (BS enabled). |
| tests/application_client/canton_transaction.py | Test client formatting and small DER-prefix/style cleanups. |
| tests/application_client/canton_response_unpacker.py | Reformats response unpacking signature/return for readability. |
| tests/application_client/canton_command_sender.py | Reformats topology-signing helper; potential formatter compliance issue. |
| src/utils.c | Standardizes assertion message text. |
| src/ui/menu_nbgl.c | Pointer-style formatting and minor cast formatting. |
| src/types.h | Pointer-style formatting. |
| src/transaction/untyped_versioned_msg.c | Updates validator ID mappings and adds mainnet dual-validator config entry. |
| src/transaction/pb_parser.c | Standardizes assertion message text. |
| src/transaction/pb_node_display_parser.c | Minor cast/deref formatting cleanup. |
| src/transaction/pb_node_display_config.c | Removes proxy-transfer display configs and tightens macro formatting. |
| src/transaction/pb_hashing_parser.c | Standardizes assertion message text. |
| src/transaction/canonical_hash.c | Standardizes assertion message text. |
| src/helper/send_reponse.c | Standardizes assertion message text (one inconsistency remains). |
| src/handler/get_version.c | Minor compound-literal formatting. |
| Makefile | Bumps app version patch (3.3.2 → 3.3.3). |
| CHANGELOG.md | Adds 3.3.3 entry describing validator/proxy-signing changes. |
| attestations/generateCryptoData.py | Removes unused variable assignment for openssl command output. |
| .pre-commit-config.yaml | Updates hook versions and adds ruff hooks (currently mis-indented). |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
tdejoigny-ledger
approved these changes
Jul 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Validator party IDs updates
Display and transaction configuration:
src/transaction/pb_node_display_config.c, effectively removing clear signing for Featured app proxy transactions. [1] [2]Error message and assertion improvements:
tx_ctxinstead oftransaction context). [1] [2] [3] [4] [5] [6] [7] [8] [9] [10] [11] [12] [13] [14] [15] [16]develop