Skip to content

Clickable GCS fields of unknown token#1012

Merged
apaillier-ledger merged 4 commits into
developfrom
feat/clickable_gcs_fields_of_unknown_token
Apr 28, 2026
Merged

Clickable GCS fields of unknown token#1012
apaillier-ledger merged 4 commits into
developfrom
feat/clickable_gcs_fields_of_unknown_token

Conversation

@apaillier-ledger

Copy link
Copy Markdown
Contributor

Description

Based on #1000

Changes include

  • Bugfix (non-breaking change that solves an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (change that is not backwards-compatible and/or changes current functionality)
  • Tests
  • Documentation
  • Other (for changes that might not fit in any category)

@apaillier-ledger apaillier-ledger force-pushed the feat/clickable_gcs_fields_of_unknown_token branch from e6c2316 to 3c352b8 Compare April 28, 2026 12:36
@github-actions

github-actions Bot commented Apr 28, 2026

Copy link
Copy Markdown
Contributor

elf sizes
source = source branch feat/clickable_gcs_fields_of_unknown_token
target = target branch develop

Device .text source .text target .text delta .bss source .bss target .bss delta max stack size source max stack size target max stack size delta
nanos2 52812 52812 0 2954 2954 0 38000 38000 0
flex 79835 79835 0 3970 3970 0 32888 32888 0
stax 79687 79687 0 3970 3970 0 32888 32888 0
nanox 52540 52540 0 2982 2982 0 8192 8192 0
apex_p 75922 75922 0 3970 3970 0 36984 36984 0

Stack consumption summary

⚠️ This summary is for informative purpose only. It may not give the application actual worst case, for example if the test coverage is low.

Device Worst case (bytes) Remaining stack (bytes) Test
apex_p 3193 15967 test_eip712.py::test_eip712_batch[apex_p]
flex 3193 11871 test_eip712.py::test_eip712_batch[flex]
nanosp 3193 17271 test_eip712.py::test_eip712_batch[nanosp]
nanox 3193 4999 test_eip712.py::test_eip712_batch[nanox]
stax 3193 11871 test_eip712.py::test_eip712_batch[stax]

Full details

@codecov-commenter

codecov-commenter commented Apr 28, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 31.57895% with 13 lines in your changes missing coverage. Please review.
✅ Project coverage is 55.95%. Comparing base (32f1e9f) to head (301bcd0).

Files with missing lines Patch % Lines
...tures/provide_erc20_token_information/token_info.c 0.00% 12 Missing ⚠️
...eatures/generic_tx_parser/gtp_param_token_amount.c 75.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #1012      +/-   ##
===========================================
- Coverage    56.26%   55.95%   -0.31%     
===========================================
  Files           26       26              
  Lines         2412     2425      +13     
  Branches       306      308       +2     
===========================================
  Hits          1357     1357              
  Misses        1017     1017              
- Partials        38       51      +13     
Flag Coverage Δ
unittests 55.95% <31.57%> (-0.31%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@apaillier-ledger apaillier-ledger force-pushed the feat/clickable_gcs_fields_of_unknown_token branch 2 times, most recently from 9f13b15 to a549af7 Compare April 28, 2026 13:03
@apaillier-ledger apaillier-ledger force-pushed the feat/clickable_gcs_fields_of_unknown_token branch from a549af7 to 8b8709f Compare April 28, 2026 15:16
@apaillier-ledger apaillier-ledger force-pushed the feat/clickable_gcs_fields_of_unknown_token branch from 8b8709f to 301bcd0 Compare April 28, 2026 15:18
@apaillier-ledger apaillier-ledger marked this pull request as ready for review April 28, 2026 15:40
@apaillier-ledger apaillier-ledger merged commit af9cb39 into develop Apr 28, 2026
651 of 653 checks passed
@apaillier-ledger apaillier-ledger deleted the feat/clickable_gcs_fields_of_unknown_token branch April 28, 2026 16:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants