Remove static networks#1044
Draft
cedelavergne-ledger wants to merge 6 commits into
Draft
Conversation
Contributor
|
elf sizes
Stack consumption summary (clone_app_stack_consumption)
Stack consumption summary
|
cedelavergne-ledger
force-pushed
the
cev/remove_static_networks
branch
4 times, most recently
from
779edc1 to
1797a5b
Compare
Code Coverage OverviewLanguages: C C / code-coverage/unittestsThe overall coverage in the branch is 93%. Coverage data for the branch is not yet available. Show a code coverage summary of the most covered files.
Updated |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #1044 +/- ##
===========================================
- Coverage 87.73% 87.73% -0.01%
===========================================
Files 92 92
Lines 7259 7257 -2
Branches 1620 1618 -2
===========================================
- Hits 6369 6367 -2
Misses 468 468
Partials 422 422
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Drop the hardcoded NETWORK_MAPPING table and resolve networks solely from dynamically loaded ones. Simplify the lookup API by removing the now-useless `dynamic` parameter. The app's own (build-time) chain is still handled via the build config: name from APPNAME, ticker from chain_config, and it is always considered Ethereum-compatible (so trusted names on the native chain keep working).
The net_icons.gen.{c,h} generator parsed the now-removed NETWORK_MAPPING and
produced an empty array. Remove the generation (Makefile rule + gen_networks.py)
and unify network_icons.c: return the dynamic network icon, else the app's own
icon for its native chain.
In swap (library) mode the dynamic network list is wiped by the signature BSS reset, so the device validates the swapped chain's ticker against the networks provided before the swap and the app's own chain config: - parse_swap_config: fees asset info stays optional (the CAL omits it for ERC20 swaps on the native chain, where the fee is the native currency). - get_asset_info_on_network: when the swap config omits the fee asset, fall back to the chain config ticker instead of the removed static table. Non-native chains (e.g. BSC) must now be provided as dynamic networks before the swap, like any other network. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
cedelavergne-ledger
force-pushed
the
cev/remove_static_networks
branch
from
1797a5b to
3969537
Compare
Contributor
Code coverage reportPer-file coverage
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description