Remove static networks

Makefile

@@ -45,16 +45,6 @@ APP_SOURCE_PATH += src
 APP_SOURCE_FILES += $(filter-out ./ethereum-plugin-sdk/src/main.c, $(wildcard ./ethereum-plugin-sdk/src/*.c))
 INCLUDES_PATH += ./ethereum-plugin-sdk/src
 
-ifeq ($(TARGET_NAME),$(filter $(TARGET_NAME),TARGET_STAX TARGET_FLEX TARGET_APEX_M TARGET_APEX_P))
-    NETWORK_ICONS_FILE = $(GEN_SRC_DIR)/net_icons.gen.c
-    NETWORK_ICONS_DIR = $(shell dirname "$(NETWORK_ICONS_FILE)")
-
-    $(NETWORK_ICONS_FILE):
-		python3 tools/gen_networks.py "$(NETWORK_ICONS_DIR)"
-
-    APP_SOURCE_FILES += $(NETWORK_ICONS_FILE)
-endif
-
 # Application icons following guidelines:
 # https://developers.ledger.com/docs/embedded-app/design-requirements/#device-icon
 ICON_NANOX = icons/nanox_app_chain_$(CHAIN_ID).gif

src/features/generic_tx_parser/gtp_param_amount.c

@@ -44,7 +44,7 @@ bool format_param_amount(const s_param_amount *param, const char *name) {
     if ((ret = value_get(&param->value, &collec))) {
         if (get_current_tx_info() == NULL) return false;
         chain_id = get_current_tx_info()->chain_id;
-        ticker = get_displayable_ticker(&chain_id, g_chain_config, true);
+        ticker = get_displayable_ticker(&chain_id, g_chain_config);
         for (int i = 0; i < collec.size; ++i) {
             if (!(ret = amountToString(collec.value[i].ptr,
                                        collec.value[i].length,

src/features/generic_tx_parser/gtp_param_token.c

@@ -76,7 +76,7 @@ bool format_param_token(const s_param_token *param, const char *name) {
 
             buf_shrink_expand(collec.value[i].ptr, collec.value[i].length, addr, sizeof(addr));
             if (match_native(addr, param)) {
-                ticker = get_displayable_ticker(&chain_id, g_chain_config, true);
+                ticker = get_displayable_ticker(&chain_id, g_chain_config);
             } else {
                 if ((token_info = get_matching_token_info_or_dummy(&chain_id, addr)) == NULL) {
                     ret = false;

src/features/generic_tx_parser/gtp_param_token_amount.c

@@ -106,7 +106,7 @@ static bool process_token_amount(const s_param_token_amount *param,
     if (param->has_token) {
         buf_shrink_expand(token->ptr, token->length, addr_buf, sizeof(addr_buf));
         if (match_native(addr_buf, param)) {
-            ticker = get_displayable_ticker(&chain_id, g_chain_config, true);
+            ticker = get_displayable_ticker(&chain_id, g_chain_config);
             decimals = WEI_TO_ETHER;
         } else {
             if ((token_info = get_matching_token_info_or_dummy(&chain_id, addr_buf)) == NULL) {

src/features/generic_tx_parser/tx_ctx.c

@@ -121,7 +121,7 @@ static bool process_empty_tx(const s_tx_ctx *tx_ctx) {
                 return false;
             }
         }
-        ticker = get_displayable_ticker(&tx_info->chain_id, g_chain_config, true);
+        ticker = get_displayable_ticker(&tx_info->chain_id, g_chain_config);
         decimals = WEI_TO_ETHER;
         if (!amountToString(tx_ctx->amount,
                             sizeof(tx_ctx->amount),

src/features/sign_message_eip712/ui_logic.c

@@ -680,7 +680,7 @@ static bool handle_fallback_empty_calldata(const s_eip712_calldata_info *calldat
             chain_id = eip712_context->chain_id;
         }
 
-        ticker = get_displayable_ticker(&chain_id, g_chain_config, true);
+        ticker = get_displayable_ticker(&chain_id, g_chain_config);
         decimals = WEI_TO_ETHER;
         if (!amountToString(calldata_info->amount,
                             sizeof(calldata_info->amount),

src/features/sign_tx/logic_sign_tx.c

@@ -228,7 +228,7 @@ static uint16_t address_to_string(uint8_t *in,
 static void raw_fee_to_string(uint256_t *rawFee, char *out_buffer, uint32_t out_buffer_size) {
     // Fees are always in the base currency, this is why we need to use the chain_id
     uint64_t chain_id = get_tx_chain_id();
-    const char *ticker = get_displayable_ticker(&chain_id, g_chain_config, true);
+    const char *ticker = get_displayable_ticker(&chain_id, g_chain_config);
     uint8_t fee_len = 0;
     uint8_t ticker_len = 0;
     char raw_fee_buffer[100] = {0};
@@ -291,7 +291,7 @@ __attribute__((noinline)) static uint16_t finalize_parsing_helper(const txContex
     char displayBuffer[50];
     uint8_t decimals = WEI_TO_ETHER;
     uint64_t chain_id = get_tx_chain_id();
-    const char *ticker = get_displayable_ticker(&chain_id, g_chain_config, true);
+    const char *ticker = get_displayable_ticker(&chain_id, g_chain_config);
     ethPluginFinalize_t pluginFinalize;
     cx_err_t error = CX_INTERNAL_ERROR;
 

src/nbgl/ui_home.c

@@ -225,8 +225,6 @@ static void prepare_and_display_home(const char *appname, const char *tagline, u
  * This function prepares the app name & tagline depending on how the application was called
  */
 static void get_appname_and_tagline(const char **appname, const char **tagline) {
-    uint64_t mainnet_chain_id;
-
     if (g_caller_app) {
         *appname = g_caller_app->name;
 
@@ -251,8 +249,7 @@ static void get_appname_and_tagline(const char **appname, const char **tagline)
             }
         }
     } else {  // Ethereum app
-        mainnet_chain_id = ETHEREUM_MAINNET_CHAINID;
-        *appname = get_network_name_from_chain_id(&mainnet_chain_id);
+        *appname = APPNAME;
     }
 }
 

src/nbgl/ui_icons.c

@@ -6,9 +6,6 @@
 #include "plugins.h"
 #include "network.h"
 #include "network_info.h"
-#ifdef SCREEN_SIZE_WALLET
-#include "net_icons.gen.h"
-#endif
 
 /**
  * Retrieve the app icon, using the caller app icon if requested
@@ -78,7 +75,8 @@ const nbgl_icon_details_t *get_tx_icon(bool fromPlugin) {
 /**
  * Get the network icon from a given chain ID
  *
- * Loops onto the generated \ref g_network_icons array until a chain ID matches.
+ * Searches the dynamically loaded networks, then falls back to the app's own
+ * icon when the requested chain is the application's native chain.
  *
  * @param[in] chain_id network's chain ID
  * @return the network icon if found, \ref NULL otherwise
@@ -90,19 +88,10 @@ const nbgl_icon_details_t *get_network_icon_from_chain_id(const uint64_t *chain_
         PRINTF("[NETWORK_ICONS] - Found dynamic '%s'\n", net_info->name);
         return PIC(&net_info->icon);
     }
-#ifdef SCREEN_SIZE_WALLET
-    for (size_t i = 0; i < ARRAYLEN(g_network_icons); ++i) {
-        if ((uint64_t) PIC(g_network_icons[i].chain_id) == *chain_id) {
-            PRINTF("[NETWORK_ICONS] - Fallback on hardcoded list.\n");
-            return PIC(g_network_icons[i].icon);
-        }
-    }
-#else
-    // Nano devices don't have the array of icons, fallback on the app's icon
-    if (*chain_id == ETHEREUM_MAINNET_CHAINID) {
+    // Fallback on the app's own icon for its native chain
+    if (*chain_id == g_chain_config->chain_id) {
         return &ICONGLYPH;
     }
-#endif
     return NULL;
 }