Migration to the SDK memory allocator#792
Merged
Merged
Conversation
apaillier-ledger
force-pushed
the
feat/apa/sdk_mem_allocator
branch
2 times, most recently
from
3e9b710 to
1bfc8f6
Compare
apaillier-ledger
force-pushed
the
feat/apa/sdk_mem_allocator
branch
from
1bfc8f6 to
355bd5c
Compare
To prevent conflicts with new one from SDK and make it explicit that it is legacy and will have to be changed.
Also added memory profiling tool
apaillier-ledger
force-pushed
the
feat/apa/sdk_mem_allocator
branch
from
355bd5c to
c87ffee
Compare
cedelavergne-ledger
previously approved these changes
May 15, 2025
…(with a small buffer) when the legacy one is being used
apaillier-ledger
force-pushed
the
feat/apa/sdk_mem_allocator
branch
from
c87ffee to
b97df9b
Compare
6 tasks
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
For easier maintainability and safer code.
EIP-712 will have to be migrated as well.
The clang static analysis is 🔴 but it comes from the SDK, which has already been fixed and a new app-builder container will have to be published.
Changes include