Skip to content

B2CA-2548: Address book#990

Open
cedelavergne-ledger wants to merge 8 commits into
developfrom
cev/B2CA_2548-address_book
Open

B2CA-2548: Address book#990
cedelavergne-ledger wants to merge 8 commits into
developfrom
cev/B2CA_2548-address_book

Conversation

@cedelavergne-ledger
Copy link
Copy Markdown
Contributor

Description

  • Update client to support Address Book
  • Add Address Book feature
  • Add Address Book tests

Changes include

  • Bugfix (non-breaking change that solves an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (change that is not backwards-compatible and/or changes current functionality)
  • Tests
  • Documentation
  • Other (for changes that might not fit in any category)

@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Apr 13, 2026

Codecov Report

❌ Patch coverage is 85.71429% with 6 lines in your changes missing coverage. Please review.
✅ Project coverage is 57.41%. Comparing base (fd46d04) to head (0536cb1).

Files with missing lines Patch % Lines
...eatures/generic_tx_parser/gtp_param_trusted_name.c 68.75% 5 Missing ⚠️
src/address_name_lookup.c 96.15% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #990      +/-   ##
===========================================
+ Coverage    56.04%   57.41%   +1.36%     
===========================================
  Files           26       28       +2     
  Lines         2414     2515     +101     
  Branches       323      330       +7     
===========================================
+ Hits          1353     1444      +91     
+ Misses        1057     1024      -33     
- Partials         4       47      +43     
Flag Coverage Δ
unittests 57.41% <85.71%> (+1.36%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@cedelavergne-ledger cedelavergne-ledger force-pushed the cev/B2CA_2548-address_book branch 2 times, most recently from 37c0909 to 8e5ee76 Compare April 13, 2026 10:22
@cedelavergne-ledger cedelavergne-ledger force-pushed the cev/B2CA_2548-address_book branch 2 times, most recently from a22cf35 to 59fede3 Compare April 21, 2026 15:21
@cedelavergne-ledger cedelavergne-ledger changed the title BACA-2548: Address book B2CA-2548: Address book Apr 21, 2026
Comment thread Makefile Outdated
Comment thread src/features/address_book/handle_provide_contact.c Outdated
Comment thread tests/ragger/test_address_book.py
Comment thread src/features/address_book/handle_identity.c Outdated
Comment thread src/features/address_book/handle_identity.c Outdated
Comment thread src/features/address_book/handle_provide_contact.c Outdated
Comment thread src/features/address_book/handle_provide_contact.c Outdated
@cedelavergne-ledger cedelavergne-ledger force-pushed the cev/B2CA_2548-address_book branch 13 times, most recently from 4f0bb27 to dd1ba28 Compare April 27, 2026 09:14
@cedelavergne-ledger cedelavergne-ledger force-pushed the cev/B2CA_2548-address_book branch 5 times, most recently from f614fd3 to 0e73307 Compare April 28, 2026 11:45
@cedelavergne-ledger cedelavergne-ledger marked this pull request as ready for review April 28, 2026 12:13
@cedelavergne-ledger cedelavergne-ledger force-pushed the cev/B2CA_2548-address_book branch from be03d9a to 203a81f Compare April 28, 2026 12:24
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Apr 28, 2026

elf sizes
source = source branch cev/B2CA_2548-address_book
target = target branch develop

Device .text source .text target .text delta .bss source .bss target .bss delta max stack size source max stack size target max stack size delta
stax 193790 180478 13312 23298 21794 1504 13560 15064 -1504
flex 194381 180557 13824 23298 21794 1504 13560 15064 -1504
apex_p 173721 160409 13312 23298 21794 1504 17656 19160 -1504
nanox 126803 114003 12800 22032 20520 1512 8192 8192 0
nanos2 127075 114275 12800 21996 20492 1504 18960 20464 -1504

Stack consumption summary (clone_app_stack_consumption)

⚠️ This summary is for informative purpose only. It may not give the application actual worst case, for example if the test coverage is low.

Device Worst case (bytes) Remaining stack (bytes) Test
apex_p 1753 38599 test_clone.py::test_clone_thundercore[apex_p]
flex 1801 34455 test_clone.py::test_clone_thundercore[flex]
nanosp 1705 38647 test_clone.py::test_clone_thundercore[nanosp]
nanox 1697 6495 test_clone.py::test_clone_thundercore[nanox]
stax 1801 34455 test_clone.py::test_clone_thundercore[stax]

Full details

Stack consumption summary

⚠️ This summary is for informative purpose only. It may not give the application actual worst case, for example if the test coverage is low.

Device Worst case (bytes) Remaining stack (bytes) Test
apex_p 3193 14463 test_address_book.py::test_address_book_gcs_empty_tx[apex_p]
flex 3193 10367 test_address_book.py::test_address_book_gcs_empty_tx[flex]
nanosp 3193 15767 test_address_book.py::test_address_book_gcs_empty_tx[nanosp]
nanox 3193 4999 test_address_book.py::test_address_book_gcs_empty_tx[nanox]
stax 3193 10367 test_address_book.py::test_address_book_gcs_empty_tx[stax]

Full details

@cedelavergne-ledger cedelavergne-ledger force-pushed the cev/B2CA_2548-address_book branch 8 times, most recently from 078b1d9 to 1f51a8f Compare May 5, 2026 12:01
@cedelavergne-ledger cedelavergne-ledger force-pushed the cev/B2CA_2548-address_book branch 2 times, most recently from a27c3c9 to aff4748 Compare May 5, 2026 16:56
@cedelavergne-ledger cedelavergne-ledger force-pushed the cev/B2CA_2548-address_book branch from aff4748 to 75b2932 Compare May 12, 2026 09:36
@cedelavergne-ledger cedelavergne-ledger requested a review from a team as a code owner May 12, 2026 09:36
@cedelavergne-ledger cedelavergne-ledger force-pushed the cev/B2CA_2548-address_book branch from 75b2932 to 0c70743 Compare May 12, 2026 09:53
@cedelavergne-ledger cedelavergne-ledger force-pushed the cev/B2CA_2548-address_book branch from 0c70743 to 0536cb1 Compare May 12, 2026 10:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants