Skip to content

✨ (solana-signer) [DSDK-1098]: Solana transaction check & Solana provide context refactor#1481

Merged
fAnselmi-Ledger merged 6 commits into
feat/no-issue-improve-typing-into-context-module-refactorfrom
feat/dsdk-1098-solana-transaction-check
May 13, 2026
Merged

✨ (solana-signer) [DSDK-1098]: Solana transaction check & Solana provide context refactor#1481
fAnselmi-Ledger merged 6 commits into
feat/no-issue-improve-typing-into-context-module-refactorfrom
feat/dsdk-1098-solana-transaction-check

♻️ (transaction-check): Polish transaction check feature

2b8241d
Select commit
Loading
Failed to load commit list.
SonarQubeCloud / SonarCloud Code Analysis failed May 13, 2026 in 1m 13s

Quality Gate failed

Failed conditions
19.9% Duplication on New Code (required ≤ 3%)

See analysis details on SonarQube Cloud

Annotations

Check warning on line 55 in packages/device-management-kit/src/api/utils/ApplicationChecker.ts

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Use `this` type instead. 

See more on https://sonarcloud.io/project/issues?id=LedgerHQ_device-sdk-ts&issues=AZ4XnNr2VmrTIp0-FXIB&open=AZ4XnNr2VmrTIp0-FXIB&pullRequest=1481

Check warning on line 223 in packages/signer/signer-solana/src/internal/app-binder/device-action/SignTransactionDeviceAction.ts

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

This assertion is unnecessary since the receiver accepts the original type of the expression. 

See more on https://sonarcloud.io/project/issues?id=LedgerHQ_device-sdk-ts&issues=AZ4XnNu7VmrTIp0-FXIH&open=AZ4XnNu7VmrTIp0-FXIH&pullRequest=1481

Check warning on line 82 in packages/signer/signer-solana/src/internal/app-binder/task/BuildTransactionContextTask.ts

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Complete the task associated to this "TODO" comment. 

See more on https://sonarcloud.io/project/issues?id=LedgerHQ_device-sdk-ts&issues=AZ4XrrFywni1vZz9vQDg&open=AZ4XrrFywni1vZz9vQDg&pullRequest=1481

Check warning on line 45 in packages/device-management-kit/src/api/utils/ApplicationChecker.ts

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Use `this` type instead. 

See more on https://sonarcloud.io/project/issues?id=LedgerHQ_device-sdk-ts&issues=AZ4XnNr2VmrTIp0-FXH_&open=AZ4XnNr2VmrTIp0-FXH_&pullRequest=1481

Check warning on line 87 in packages/signer/signer-solana/src/internal/app-binder/task/BuildTransactionContextTask.test.ts

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Complete the task associated to this "TODO" comment. 

See more on https://sonarcloud.io/project/issues?id=LedgerHQ_device-sdk-ts&issues=AZ4X2F2ApnUsgexYP9y5&open=AZ4X2F2ApnUsgexYP9y5&pullRequest=1481

Check warning on line 207 in packages/signer/signer-solana/src/internal/app-binder/device-action/SignTransactionDeviceAction.ts

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

This assertion is unnecessary since the receiver accepts the original type of the expression. 

See more on https://sonarcloud.io/project/issues?id=LedgerHQ_device-sdk-ts&issues=AZ4XnNu7VmrTIp0-FXIF&open=AZ4XnNu7VmrTIp0-FXIF&pullRequest=1481

Check warning on line 216 in packages/signer/signer-solana/src/internal/app-binder/device-action/SignTransactionDeviceAction.ts

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

This assertion is unnecessary since the receiver accepts the original type of the expression. 

See more on https://sonarcloud.io/project/issues?id=LedgerHQ_device-sdk-ts&issues=AZ4XnNu7VmrTIp0-FXIG&open=AZ4XnNu7VmrTIp0-FXIG&pullRequest=1481

Check warning on line 50 in packages/device-management-kit/src/api/utils/ApplicationChecker.ts

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Use `this` type instead. 

See more on https://sonarcloud.io/project/issues?id=LedgerHQ_device-sdk-ts&issues=AZ4XnNr2VmrTIp0-FXIA&open=AZ4XnNr2VmrTIp0-FXIA&pullRequest=1481
View more details on SonarQubeCloud