fix(installer): replace silent || true masks with warnings in phase scripts#952
Conversation
Lightheartdevs
left a comment
There was a problem hiding this comment.
Exactly the right fix — directly addresses the CLAUDE.md rule ("Never || true or 2>/dev/null"). Converts silent failure masks into named warn calls with specific messages ("Source copy incomplete — some files may be missing", etc.) and routes stderr to LOG_FILE for diagnostics.
The awk pipeline refactor in 11-services.sh is a nice bonus: loop-based approach is more readable and lets each key patch report failure independently.
Flag: #953 (BATS tests) appears to carry these same changes. Land this one first, then #953 can rebase cleanly.
Lightheartdevs
left a comment
There was a problem hiding this comment.
Focused change, good direction, and current checks are green. Replacing silent masks with visible warnings improves operator feedback without changing the happy path. Approved.
Summary
cpfails instead of silently proceeding with missing files; chmod failures warn that scripts may not be executable; OpenClaw default config copy failure now warns the user.envpatching loop now checks each awk/cat/rm chain individually and warns on failure instead of always printing success/dev/nullTest plan
--dry-runto verify no syntax errors in modified phase scripts/tmp/dream-server-install.logwhen copy/patch operations failbash -non both modified phase scripts to confirm no syntax errors