Skip to content

fix(installer): replace silent || true masks with warnings in phase scripts#952

Merged
Lightheartdevs merged 2 commits intoLight-Heart-Labs:mainfrom
boffin-dmytro:fix/installer-silent-error-masks
Apr 18, 2026
Merged

fix(installer): replace silent || true masks with warnings in phase scripts#952
Lightheartdevs merged 2 commits intoLight-Heart-Labs:mainfrom
boffin-dmytro:fix/installer-silent-error-masks

Conversation

@boffin-dmytro
Copy link
Copy Markdown
Contributor

Summary

  • Phase 06 (directories): source copy fallback now warns when cp fails instead of silently proceeding with missing files; chmod failures warn that scripts may not be executable; OpenClaw default config copy failure now warns the user
  • Phase 11 (services): .env patching loop now checks each awk/cat/rm chain individually and warns on failure instead of always printing success
  • Errors are logged to the install log file instead of discarded to /dev/null

Test plan

  • Run installer with --dry-run to verify no syntax errors in modified phase scripts
  • Verify warnings appear in /tmp/dream-server-install.log when copy/patch operations fail
  • Run bash -n on both modified phase scripts to confirm no syntax errors

Copy link
Copy Markdown
Collaborator

@Lightheartdevs Lightheartdevs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Exactly the right fix — directly addresses the CLAUDE.md rule ("Never || true or 2>/dev/null"). Converts silent failure masks into named warn calls with specific messages ("Source copy incomplete — some files may be missing", etc.) and routes stderr to LOG_FILE for diagnostics.

The awk pipeline refactor in 11-services.sh is a nice bonus: loop-based approach is more readable and lets each key patch report failure independently.

Flag: #953 (BATS tests) appears to carry these same changes. Land this one first, then #953 can rebase cleanly.

Copy link
Copy Markdown
Collaborator

@Lightheartdevs Lightheartdevs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Focused change, good direction, and current checks are green. Replacing silent masks with visible warnings improves operator feedback without changing the happy path. Approved.

@Lightheartdevs Lightheartdevs merged commit 1843ebd into Light-Heart-Labs:main Apr 18, 2026
28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants