Skip to content

update model message #20753

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Apr 25, 2025
Merged

update model message #20753

merged 8 commits into from
Apr 25, 2025

Conversation

Borda
Copy link
Member

@Borda Borda commented Apr 24, 2025

What does this PR do?

suggested by @nohalon

Before submitting
  • Was this discussed/agreed via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or minor internal changes/refactors)

PR review

Anyone in the community is welcome to review the PR.
Before you start reviewing, make sure you have read the review guidelines. In short, see the following bullet-list:

Reviewer checklist
  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

📚 Documentation preview 📚: https://pytorch-lightning--20753.org.readthedocs.build/en/20753/

cc @Borda @lantiga @justusschock

@github-actions github-actions bot added the pl Generic label for PyTorch Lightning package label Apr 24, 2025
Copy link
Contributor

github-actions bot commented Apr 24, 2025

⚡ Required checks status: All passing 🟢

Groups summary

🟢 pytorch_lightning: Tests workflow
Check ID Status
pl-cpu-guardian success

These checks are required after the changes to src/lightning/pytorch/trainer/connectors/callback_connector.py.

🟢 pytorch_lightning: Azure GPU
Check ID Status
pytorch-lightning (GPUs) (testing Lightning | latest) success
pytorch-lightning (GPUs) (testing PyTorch | latest) success

These checks are required after the changes to src/lightning/pytorch/trainer/connectors/callback_connector.py.

🟢 pytorch_lightning: Benchmarks
Check ID Status
lightning.Benchmarks success

These checks are required after the changes to src/lightning/pytorch/trainer/connectors/callback_connector.py.

🟢 fabric: Docs
Check ID Status
docs-make (fabric, doctest) success
docs-make (fabric, html) success

These checks are required after the changes to docs/source-fabric/conf.py, .github/workflows/docs-build.yml.

🟢 pytorch_lightning: Docs
Check ID Status
docs-make (pytorch, doctest) success
docs-make (pytorch, html) success

These checks are required after the changes to src/lightning/pytorch/trainer/connectors/callback_connector.py, docs/source-pytorch/conf.py, .github/workflows/docs-build.yml.

🟢 mypy
Check ID Status
mypy success

These checks are required after the changes to src/lightning/pytorch/trainer/connectors/callback_connector.py.

🟢 install
Check ID Status
install-pkg-guardian success

These checks are required after the changes to src/lightning/pytorch/trainer/connectors/callback_connector.py.


Thank you for your contribution! 💜

Note
This comment is automatically generated and updates for 60 minutes every 180 seconds. If you have any other questions, contact carmocca for help.

Copy link

codecov bot commented Apr 24, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79%. Comparing base (1af7f73) to head (22cddfc).
Report is 1 commits behind head on master.

✅ All tests successful. No failed tests found.

❗ There is a different number of reports uploaded between BASE (1af7f73) and HEAD (22cddfc). Click for more details.

HEAD has 363 uploads less than BASE
Flag BASE (1af7f73) HEAD (22cddfc)
gpu 4 0
pytest 58 0
lightning_fabric 27 0
lightning 61 15
cpu 108 27
python3.10 24 6
python 12 3
python3.12 12 3
python3.12.7 36 9
python3.11 24 6
pytorch2.1 12 6
pytorch_lightning 24 12
pytest-full 54 27
pytorch2.2.2 6 3
pytorch2.3 6 3
pytorch2.5 6 3
pytorch2.4.1 6 3
pytorch2.7 6 3
pytorch2.5.1 6 3
pytorch2.6 6 3
Additional details and impacted files
@@            Coverage Diff            @@
##           master   #20753     +/-   ##
=========================================
- Coverage      87%      79%     -8%     
=========================================
  Files         268      265      -3     
  Lines       23452    23397     -55     
=========================================
- Hits        20391    18387   -2004     
- Misses       3061     5010   +1949     

@github-actions github-actions bot added docs Documentation related dependencies Pull requests that update a dependency file labels Apr 24, 2025
@github-actions github-actions bot added the ci Continuous Integration label Apr 25, 2025
@Borda Borda requested a review from williamFalcon as a code owner April 25, 2025 15:19
@github-actions github-actions bot added the fabric lightning.fabric.Fabric label Apr 25, 2025
@mergify mergify bot added the ready PRs ready to be merged label Apr 25, 2025
@Borda Borda merged commit 6cf2581 into master Apr 25, 2025
83 checks passed
@Borda Borda deleted the models-msg-update branch April 25, 2025 17:49
Borda added a commit that referenced this pull request Apr 25, 2025
* update model message
* nitpick_ignore

(cherry picked from commit 6cf2581)
Borda added a commit that referenced this pull request Apr 25, 2025
* update model message
* nitpick_ignore

(cherry picked from commit 6cf2581)
lexierule pushed a commit that referenced this pull request Apr 25, 2025
* update model message
* nitpick_ignore

(cherry picked from commit 6cf2581)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci Continuous Integration dependencies Pull requests that update a dependency file docs Documentation related fabric lightning.fabric.Fabric pl Generic label for PyTorch Lightning package ready PRs ready to be merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants