Skip to content

update model message #20753

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Apr 25, 2025
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/docs-build.yml
Original file line number Diff line number Diff line change
Expand Up @@ -72,7 +72,7 @@ jobs:
lfs: ${{ matrix.pkg-name == 'pytorch' }}
- uses: actions/setup-python@v5
with:
python-version: "3.9"
python-version: "3.10"

- name: List notebooks
if: ${{ matrix.pkg-name == 'pytorch' }}
Expand Down
2 changes: 2 additions & 0 deletions docs/source-fabric/conf.py
Original file line number Diff line number Diff line change
Expand Up @@ -292,6 +292,8 @@
("py:.*", "torch_xla.*"),
("py:class", "transformer_engine.*"),
("py:class", "bitsandbytes.*"),
# loggers
('py:class', 'tensorboardX.SummaryWriter'), # todo: this is unexpected as the imports locally works
]

# -- Options for todo extension ----------------------------------------------
Expand Down
1 change: 1 addition & 0 deletions docs/source-pytorch/conf.py
Original file line number Diff line number Diff line change
Expand Up @@ -377,6 +377,7 @@ def _load_py_module(name: str, location: str) -> ModuleType:
# missing in generated API
("py:exc", "MisconfigurationException"),
# TODO: generated list of all existing ATM, need to be fixed
('py:class', 'tensorboardX.SummaryWriter'),
("py:class", "AveragedModel"),
("py:class", "CometExperiment"),
("py:meth", "DataModule.__init__"),
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -106,9 +106,8 @@ def _configure_checkpoint_callbacks(self, enable_checkpointing: bool) -> None:
model_checkpoint = LitModelCheckpoint(model_registry=self.trainer._model_registry)
else:
rank_zero_info(
"You are using the default ModelCheckpoint callback."
" Install `pip install litmodels` package to use the `LitModelCheckpoint` instead"
" for seamless uploading to the Lightning model registry."
"Using default `ModelCheckpoint`. Consider installing `litmodels` package to enable"
" `LitModelCheckpoint` for automatic upload to the Lightning model registry."
)
model_checkpoint = ModelCheckpoint()
self.trainer.callbacks.append(model_checkpoint)
Expand Down
Loading