Skip to content

Revert #20825 & fix sigterm exception handling#21666

Open
deependujha wants to merge 2 commits intomasterfrom
fix/sigterm-ddp
Open

Revert #20825 & fix sigterm exception handling#21666
deependujha wants to merge 2 commits intomasterfrom
fix/sigterm-ddp

Conversation

@deependujha
Copy link
Copy Markdown
Collaborator

@deependujha deependujha commented Apr 18, 2026

What does this PR do?

Fixes #<issue_number>
reverts commit #20825

Before submitting
  • Was this discussed/agreed via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or minor internal changes/refactors)

PR review

Anyone in the community is welcome to review the PR.
Before you start reviewing, make sure you have read the review guidelines. In short, see the following bullet-list:

Reviewer checklist
  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

📚 Documentation preview 📚: https://pytorch-lightning--21666.org.readthedocs.build/en/21666/

@github-actions github-actions Bot added the pl Generic label for PyTorch Lightning package label Apr 18, 2026
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Apr 18, 2026

⚡ Required checks status: All passing 🟢

Groups summary

🟢 pytorch_lightning: Tests workflow
Check ID Status
pl-cpu-guardian success
🟢 pytorch_lightning: lit GPU
Check ID Status
pytorch.yml / Lit Job (nvidia/cuda:12.1.1-devel-ubuntu22.04, pytorch, 3.10) success
pytorch.yml / Lit Job (lightning, 3.12) success
pytorch.yml / Lit Job (pytorch, 3.12) success
🟢 Benchmarks
Check ID Status
benchmark.yml / Lit Job (fabric) success
benchmark.yml / Lit Job (pytorch) success
🟢 pytorch_lightning: Docs
Check ID Status
docs-make (pytorch, doctest) success
docs-make (pytorch, html) success
🟢 mypy
Check ID Status
mypy success
🟢 install
Check ID Status
install-pkg-guardian success

This comment was automatically generated and updates for 70 minutes every 180 seconds.

Thank you for your contribution! 💜

@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 18, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 79%. Comparing base (efb7328) to head (b4794f7).
✅ All tests successful. No failed tests found.

❗ There is a different number of reports uploaded between BASE (efb7328) and HEAD (b4794f7). Click for more details.

HEAD has 2040 uploads less than BASE
Flag BASE (efb7328) HEAD (b4794f7)
cpu 500 42
python 36 3
lightning_fabric 160 0
pytest 250 0
python3.12 143 12
lightning 180 15
python3.11 72 6
python3.10 36 3
python3.13 105 9
python3.12.7 108 9
pytorch2.1 36 6
pytorch_lightning 160 27
pytest-full 250 42
pytorch2.7 18 3
pytorch2.10 35 6
pytorch2.8 35 6
pytorch2.2.2 18 3
pytorch2.3 18 3
pytorch2.5.1 18 3
pytorch2.9 36 6
pytorch2.4.1 18 3
pytorch2.6 18 3
Additional details and impacted files
@@            Coverage Diff            @@
##           master   #21666     +/-   ##
=========================================
- Coverage      87%      79%     -8%     
=========================================
  Files         270      267      -3     
  Lines       23973    23895     -78     
=========================================
- Hits        20751    18797   -1954     
- Misses       3222     5098   +1876     

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pl Generic label for PyTorch Lightning package

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant