Fix bash build output path to match standardized build layout#133
Open
Fix bash build output path to match standardized build layout#133
Conversation
m-hemmings
added a commit
that referenced
this pull request
Mar 11, 2026
* Remove old rawposix * New RawPOSIX codebase setup * Add rawposix fs_calls implementation and tests * Add rawposix fs_calls implementation and tests * Vmmap-related calls * Add more comments and update kernel close * Sync with simple-syscall * Modified close_syscall * Add threei * Integrate wasmtime * Add readme * Commit fix * PR fix * PR fix * PR fix * [Refactor] Extracted cage into a standalone library (#133) * Extracted cage into a standalone library * rename and rm signal * remove debug print * address comments, refactor forkvmmap * change function signature * start to move interface and remove compilation errors * remove/port interface timer file, consolidate shm calls * format and update toml * fix cage struct and signal functions * update toml * fix compilation errors, remove interface refs * change vmmap path/sigs * remove commented code, update disable signal feature * add cage crate to wasmtime toml * add symlink * format * readd interface files to orig rawposix for CI * readd interface files to orig rawposix for CI * readd interface files to orig rawposix for CI * readd interface files to orig rawposix for CI * readd interface files to orig rawposix for CI * update tomls * linter update * Added rawposix dependency to wasmtime folder * Location of Dockerfile updated in cloudbuild script * Copy cage folder explicitly while building wasmtime in e2e test * Move Dockerfiles and references to them (#328) * 257 ci enable dependabot for GitHub actions (#330) * Add default depandabot.yml file * Update default file for workflow monitoring * Add zizmor installation and run to lint.yml (#329) * Add condition to prevent running on draft PRs (#333) * Add condition to prevent running on draft PRs * Add condition to prevent linter running on draft PRs too * Add pull_request types to include ready_for_review * deps(gha)(deps): bump docker/setup-buildx-action in /.github/workflows Bumps [docker/setup-buildx-action](https://github.com/docker/setup-buildx-action) from 3.11.0 to 3.11.1. - [Release notes](https://github.com/docker/setup-buildx-action/releases) - [Commits](docker/setup-buildx-action@18ce135...e468171) --- updated-dependencies: - dependency-name: docker/setup-buildx-action dependency-version: 3.11.1 dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> * deps(gha)(deps): bump docker/metadata-action in /.github/workflows Bumps [docker/metadata-action](https://github.com/docker/metadata-action) from 5.7.0 to 5.8.0. - [Release notes](https://github.com/docker/metadata-action/releases) - [Commits](docker/metadata-action@902fa8e...c1e5197) --- updated-dependencies: - dependency-name: docker/metadata-action dependency-version: 5.8.0 dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> * deps(gha)(deps): bump docker/login-action in /.github/workflows Bumps [docker/login-action](https://github.com/docker/login-action) from 3.4.0 to 3.5.0. - [Release notes](https://github.com/docker/login-action/releases) - [Commits](docker/login-action@74a5d14...184bdaa) --- updated-dependencies: - dependency-name: docker/login-action dependency-version: 3.5.0 dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> * deps(gha)(deps): bump actions/checkout in /.github/workflows Bumps [actions/checkout](https://github.com/actions/checkout) from 4.2.2 to 5.0.0. - [Release notes](https://github.com/actions/checkout/releases) - [Changelog](https://github.com/actions/checkout/blob/main/CHANGELOG.md) - [Commits](actions/checkout@11bd719...08c6903) --- updated-dependencies: - dependency-name: actions/checkout dependency-version: 5.0.0 dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com> * deps(gha)(deps): bump Swatinem/rust-cache in /.github/workflows Bumps [Swatinem/rust-cache](https://github.com/swatinem/rust-cache) from 2.7.8 to 2.8.0. - [Release notes](https://github.com/swatinem/rust-cache/releases) - [Changelog](https://github.com/Swatinem/rust-cache/blob/master/CHANGELOG.md) - [Commits](Swatinem/rust-cache@9d47c6a...98c8021) --- updated-dependencies: - dependency-name: Swatinem/rust-cache dependency-version: 2.8.0 dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> * deps(gha)(deps): bump actions/cache in /.github/workflows Bumps [actions/cache](https://github.com/actions/cache) from 4.2.3 to 4.2.4. - [Release notes](https://github.com/actions/cache/releases) - [Changelog](https://github.com/actions/cache/blob/main/RELEASES.md) - [Commits](actions/cache@5a3ec84...0400d5f) --- updated-dependencies: - dependency-name: actions/cache dependency-version: 4.2.4 dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> * Syscall number unification in glibc from main (#335) * Syscall number unification in glibc * Restore unlinkat syscall entry in syscalls.list per review comment * Restore original license header in dup2.c per review comment * Replace hardcoded sigprocmask syscall number with macro from lind_syscall_num.h * Restore access.c and replace hardcoded syscall number with ACCESS_SYSCALL macro * Update execve.c to use EXECVE_SYSCALL macro * Update mprotect.c to use MPROTECT_SYSCALL macro * Update lind_syscall_num.h: align syscall macros with Linux syscall table (e.g., ACCESS, DUP, DUP2, EXECVE, SIGPROCMASK, MPROTECT) * Update CLOCK_GETTIME_SYSCALL to match Linux syscall number 228 * Align lind_syscall_num.h syscall numbers with official Linux x86_64 syscall table * Restore unintentionally deleted blank lines in syscall-template.h * Fix: Revert unintended changes in dup.c and ensure correct syscall usage via DUP_SYSCALL macro * Fix: Restore formatting and apply FCNTL_SYSCALL macro in fcntl.c * Update getdents.c to use GETDENTS_SYSCALL macro and restore formatting * Fix: Apply LSEEK_SYSCALL macro and restore formatting in lseek.c * Replace hardcoded syscall number and fixed the formatting for better readibility * Replace hardcoded syscall number with SYSCALL_SIGPROCMASK macro in sigprocmask.c * Fix: Replace syscall 149 with SYSCALL_SIGPROCMASK and clean up aliases in sigprocmask.c * Refactor: Improve formatting and readability in sigprocmask.c * Refactor: Improve formatting and readability in sigprocmask.c * revert to minimise git diff * revert to minimise git diff * revert to minimise git diff * revert to minimise git diff * revert to minimise git diff * revert to minimise git diff * replace syscall num in glibc * deleted make syscall commented code * extra space change * additional space change * deleted alias and execve under linux * Sort number * Change missing syscall * Fix setsockopt * Add dup3 and remove mutex/cond * Remove obsolete lind_platform related files * Update sigaction * Merge tmp-main * Update wasmtime syscall num to align with linux version (#326) Co-authored-by: Nicholas Renner <nicholassrenner@gmail.com> * Updated dispatcher.rs to match glibc syscall numbers * Fixed syntax error in futex-internal.c * Resolved comment on newline * Use syscall constants in lib.rs * Minor fix * Added kill symbol to kill.c in sysdeps * Added dup symbol back to dup.c * Added munmap symbol * Reset fork syscall set to 57 * Added linux repo link for syscall table * Added signal callback export to lind_compile * Added clone3 reference to macro * Added newlines as per comments * Organised wasmtime syscall numbers in numerical ascending order --------- Co-authored-by: Alice W <wenyaxuan0925@outlook.com> Co-authored-by: Mohd Sarfaraz Faiyaz <102454287+bblackheart013@users.noreply.github.com> Co-authored-by: xhanghe <mikaelhi1213@gmail.com> Co-authored-by: Alice Wen <40227173+Yaxuan-w@users.noreply.github.com> Co-authored-by: Nicholas Renner <nicholassrenner@gmail.com> * 301 redo migration to clang 18 (#314) * Update LLVM and CLANG versions in dev Dockerfile * Add libtinfo5 to dev Dockerfile * add cflags to include fPIC * bump version of clang in sys_include for making sysroot * Add manual compilation of elision lock and unlock * Update list of .o files * Correct $$ to $ for translation from Bazel to Make * update version number for clang in patching glibc wasi * Change version of llvm and clang in Dockerfile.e2e * Install libtinfo5 in Dockerfile.e2e * Add wget to Dockerfile.e2e * Added test files and make target for test to troubleshoot staged building issues * Add robust failure tolerance for curl to prevent failures * resolve clang resource dir dynamically * Remove leftover troubleshooting code and scripts * Update gitignore to not track clang files or folders * Comment curl changes for retries etc * Remove heavy-handed confirmation in curl * Update exclusions and filter out invalid .o files in sysroot build * Fixes make clean (#354) * Temporary fix * Makefile: used find * revert instance.rs --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: Nicholas Renner <nicholassrenner@gmail.com> Co-authored-by: Sankalp Ramesh <ssannkkallpp@gmail.com> Co-authored-by: MHemmings <discount.yoyos@gmail.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Mohd Sarfaraz Faiyaz <102454287+bblackheart013@users.noreply.github.com> Co-authored-by: xhanghe <mikaelhi1213@gmail.com> Co-authored-by: Jeetesh Gowder <147194458+J7-7-7@users.noreply.github.com> * [Refactor] Add type conversion library (#134) * Add typemap library * Add more comments and change file name of fs related type conversion * Rename file name * Replace magic number with Errno and add comments to explain upper bit check * Reorganize file and fmt * fmt * Clean rawposix diff * Some fix according to the working version. Add more syscall. * Fixes according to working version * [Refactor] Remove obsolete src/RawPOSIX (#364) * Fix imports and dependencies * Align toml * update imports according to the threei-integration-test branch * local changes before merging simple-syscall * remove test file * Add comments * update mmap and add type conversion function for mut u8 * Refactor and add new method to vmctx table + add placeholder for unused arg + add comments * Remove extra lines * Use different unused constants + add comments * resolve comments * Rename constants * Resolve comments * Add validation function * Add todo * fix: rm comment * feat: update flags * feat: update to use handle_errorno * feat: updated panics * feat: update to return with actual brk error from the syscall * feat: updated to return brk_result * Add comments to mem init workflow + null constants * Change constants * add validate_cageid function * update validation type conversion function with new null constants * Remove unused imports * Fix imports * Add type_conv func for path * [Refactor] Add glibc 3i support (#308) * [Refactor] 4 simple type conversion syscall [read / open / close / mkdir] (#376) * [Refactor] Add Threei (#237) * [Refactor] Added write/pipe/pipe2 implementation (#392) * [Refactor] Add basic network syscalls to 3i (socket / connect / bind / listen / accept / setsockopt / send) (#412) * [Refactor] Add system calls to 3i (#389) * [Refactor] Add network syscalls in rawposix[recv/sendto/recvfrom/gethostname/get… (#382) * [Refactor] Implement Filesystem Syscalls (#388) * [Refactor] File system calls threei (#387) * [Refactor] Poll/select/epoll syscall implementations (#394) * [Refactor] Threei integration patch: conflict fixes, and cageid and unused arg panic enforcement (#426) * [Refactor] Threei integration patch for syscalls (#428) * [Refactor] Add shared memory syscalls to 3i (#427) * Merge build and test scripts into threei-integration * Resolve merge conflicts * Cargo fmt * Linter fix * Test e2e fix * Remove unused timer file + revert glibc files + remove comments * Revert glibc file * Change comment * Rename test file --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: quynhhuong <hh3009@nyu.edu> Co-authored-by: Nicholas Renner <nicholassrenner@gmail.com> Co-authored-by: Sankalp Ramesh <ssannkkallpp@gmail.com> Co-authored-by: MHemmings <discount.yoyos@gmail.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Mohd Sarfaraz Faiyaz <102454287+bblackheart013@users.noreply.github.com> Co-authored-by: xhanghe <mikaelhi1213@gmail.com> Co-authored-by: Jeetesh Gowder <147194458+J7-7-7@users.noreply.github.com> Co-authored-by: ChinmayShringi <chinmayshringi4@gmail.com> Co-authored-by: Huong Hoang <68453624+celinehoang177@users.noreply.github.com> Co-authored-by: Runbin Yuan <144069479+robinyuan1002@users.noreply.github.com> Co-authored-by: Chinmay Shringi <31031919+ChinmayShringi@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
@thisisadi Could you also please ensure that the bash binary copied to the build folder follows the specification listed in #125?
Author
|
@vidyalakshmir |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #125
Fixes the bash build artifact path to match the standardized layout.
Artifacts are now placed in:
build/bash/bin/bash/
instead of:
build/bash/bin/wasm32-wasi/