Skip to content

Fix bash build output path to match standardized build layout #133

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
thisisadi wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Fix bash build output path to match standardized build layout #133

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3037ab6
Fix bash build output path to match standardized build layout
thisisadi Mar 7, 2026
a0f26b9
Resolve merge conflicts and stage bash binary without .cwasm extension
thisisadi Mar 14, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -148,7 +148,7 @@ lmbench: libtirpc merge-sysroot
# ---------------- bash (WASM build) -------------------------------------------
# Uses bash/compile_bash.sh to build bash as a wasm32-wasi binary using the
# merged sysroot and toolchain detected by preflight, and stages artifacts
# under build/bin/bash/wasm32-wasi/.
# under build/bash/bin/bash.
bash: merge-sysroot
. '$(TOOL_ENV)'
'$(APPS_ROOT)/bash/compile_bash.sh'
Expand Down
2 changes: 1 addition & 1 deletion bash/compile_bash.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,7 +63,7 @@ LIND_BOOT="${LIND_BOOT:-$LIND_WASM_ROOT/build/lind-boot}"
JOBS="${JOBS:-$(nproc 2>/dev/null || getconf _NPROCESSORS_ONLN || echo 4)}"

# Output location
BASH_OUT_DIR="$APPS_ROOT/build/bin/bash/wasm32-wasi"
BASH_OUT_DIR="$APPS_ROOT/build/bash/bin/bash"
Copy link
Contributor

@vidyalakshmir vidyalakshmir Mar 16, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please change this to
"$APPS_ROOT/build/bash/bin"

mkdir -p "$BASH_OUT_DIR"

# wasm_compat header is committed in the repo
Expand Down