Updated Credits for PoP #1987
Updated Credits for PoP #1987
Conversation
GMPranav
commented
Oct 30, 2024
GMPranav
commented
- My Auto Splitter does not contain any malicious functionality and I'm entirely responsible for any damages myself.
- I am not replacing an existing Auto Splitter by a different author, or I have received permission from the author to replace the existing Auto Splitter.
- The Auto Splitter has an open source license that allows anyone to fork and host it.
LiveSplit.AutoSplitters.xml
Outdated
| <URL>https://raw.githubusercontent.com/PoPRuns/PoP.AutoSplitters/main/pop_sot.asl</URL> | ||
| <URL>https://raw.githubusercontent.com/PoPRuns/PoP.AutoSplitters/main/pop_ww.asl</URL> | ||
| <URL>https://raw.githubusercontent.com/PoPRuns/PoP.AutoSplitters/main/pop_t2t.asl</URL> |
There was a problem hiding this comment.
This change doesn't make sense. Why are you downloading multiple asl files for one autosplitter?
There was a problem hiding this comment.
Yes, I am loading these from multipop.asl
There was a problem hiding this comment.
I strongly disagree with that approach.
There was a problem hiding this comment.
Well, it avoids having to maintain splits in two places. And for such a rarely touch category extension, it's good enough.
There was a problem hiding this comment.
You could offload the settings to an entirely separate file which is loaded by both the individual ASL and the multi-ASL.
I see a flaw in your approach in that when the runner changes any settings in the multi-ASL while one of the games is running, this change is not translated over to the ASL on the layout.
There was a problem hiding this comment.
I could move the settings to another file, but then the splits logic would still have to be written in multipop.asl again. And updated if it's updated in the individual games.
Yes I am aware of this limitation. The solution is to set settings before starting a run, I have made the runners aware of it too.
There was a problem hiding this comment.
You are also removing the ASL component when the timer resets. I'm not sure that's appropriate.
There was a problem hiding this comment.
I have reverted the multipop changes, all things considered I think it's not a good approach. Plus apparently it's not even working reliably for a runner lol.
There was a problem hiding this comment.
Feel free to try again another time. I think the idea is fine, the implementation just needs some work.
GMPranav
changed the title
2 participants
