Skip to content

Updated Credits for PoP #1987

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 31, 2024
Merged

Updated Credits for PoP #1987

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b45e054
Loading Sands Trilogy Splitters for Multi-PoP, Updated Credits
GMPranav Oct 30, 2024
9cd8c24
Reverted multipop changes
GMPranav Oct 31, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 10 additions & 7 deletions LiveSplit.AutoSplitters.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -852,7 +852,7 @@
<URL>https://github.com/just-ero/asl-help/raw/76750096863b03e7ebfdf748aef6d5d9464176a4/lib/asl-help</URL>
</URLs>
<Type>Script</Type>
<Description>Autosplitting and load removal is available. (By diggity and Meta)</Description>
<Description>Autosplitting and load removal is available. (By diggity and GMP)</Description>
</AutoSplitter>
<AutoSplitter>
<Games>
Expand Down Expand Up @@ -9822,7 +9822,7 @@
<URL>https://raw.githubusercontent.com/PoPRuns/PoP.AutoSplitters/main/pop_tfs.asl</URL>
</URLs>
<Type>Script</Type>
<Description>Automatic start, split, reset and load-removal (by Samabam and SuicideMachine)</Description>
<Description>Automatic start, split, reset and load-removal (by Samabam and GMP)</Description>
</AutoSplitter>
<AutoSplitter>
<Games>
Expand Down Expand Up @@ -11904,7 +11904,7 @@
<URL>https://raw.githubusercontent.com/PoPRuns/PoP.AutoSplitters/main/pop_sot.asl</URL>
</URLs>
<Type>Script</Type>
<Description>Automatic start, split and reset (by Samabam and Ynscription)</Description>
<Description>Automatic start, split and reset (by Samabam and GMP)</Description>
</AutoSplitter>
<AutoSplitter>
<Games>
Expand Down Expand Up @@ -11964,7 +11964,7 @@
<URL>https://raw.githubusercontent.com/PoPRuns/PoP.AutoSplitters/main/pop_ww.asl</URL>
</URLs>
<Type>Script</Type>
<Description>Automatic start, split and reset (by Creditor)</Description>
<Description>Automatic start, split and reset (by Creditor and GMP)</Description>
</AutoSplitter>
<AutoSplitter>
<Games>
Expand All @@ -11990,7 +11990,7 @@
<URL>https://raw.githubusercontent.com/PoPRuns/PoP.AutoSplitters/main/pop_t2t.asl</URL>
</URLs>
<Type>Script</Type>
<Description>Automatic start, split and reset (by Samabam)</Description>
<Description>Automatic start, split and reset (by Samabam and GMP)</Description>
</AutoSplitter>
<AutoSplitter>
<Games>
Expand Down Expand Up @@ -13220,7 +13220,7 @@
<URL>https://raw.githubusercontent.com/PoPRuns/PoP.AutoSplitters/main/pop_2008.asl</URL>
</URLs>
<Type>Script</Type>
<Description>Automatic start, split and reset (by Samabam)</Description>
<Description>Automatic start, split and reset (by Samabam and GMP)</Description>
</AutoSplitter>
<AutoSplitter>
<Games>
Expand Down Expand Up @@ -14654,9 +14654,12 @@
</Games>
<URLs>
<URL>https://raw.githubusercontent.com/PoPRuns/PoP.AutoSplitters/main/multipop.asl</URL>
<URL>https://raw.githubusercontent.com/PoPRuns/PoP.AutoSplitters/main/pop_sot.asl</URL>
<URL>https://raw.githubusercontent.com/PoPRuns/PoP.AutoSplitters/main/pop_ww.asl</URL>
<URL>https://raw.githubusercontent.com/PoPRuns/PoP.AutoSplitters/main/pop_t2t.asl</URL>
Copy link
Contributor

@just-ero just-ero Oct 30, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change doesn't make sense. Why are you downloading multiple asl files for one autosplitter?

Copy link
Contributor Author

@GMPranav GMPranav Oct 30, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, I am loading these from multipop.asl

Copy link
Contributor

@just-ero just-ero Oct 30, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I strongly disagree with that approach.

Copy link
Contributor Author

@GMPranav GMPranav Oct 30, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well, it avoids having to maintain splits in two places. And for such a rarely touch category extension, it's good enough.

Copy link
Contributor

@just-ero just-ero Oct 30, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You could offload the settings to an entirely separate file which is loaded by both the individual ASL and the multi-ASL.
I see a flaw in your approach in that when the runner changes any settings in the multi-ASL while one of the games is running, this change is not translated over to the ASL on the layout.

Copy link
Contributor Author

@GMPranav GMPranav Oct 30, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I could move the settings to another file, but then the splits logic would still have to be written in multipop.asl again. And updated if it's updated in the individual games.

Yes I am aware of this limitation. The solution is to set settings before starting a run, I have made the runners aware of it too.

Copy link
Contributor

@just-ero just-ero Oct 31, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You are also removing the ASL component when the timer resets. I'm not sure that's appropriate.

Copy link
Contributor Author

@GMPranav GMPranav Oct 31, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have reverted the multipop changes, all things considered I think it's not a good approach. Plus apparently it's not even working reliably for a runner lol.

Copy link
Contributor

@just-ero just-ero Oct 31, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Feel free to try again another time. I think the idea is fine, the implementation just needs some work.

</URLs>
<Type>Script</Type>
<Description>Automatic start, split and load-removal/IGT (by Samabam, Smathlax, GMP, et al.)</Description>
<Description>Automatic start, split and load-removal/IGT (by GMP)</Description>
</AutoSplitter>
<AutoSplitter>
<Games>
Expand Down