Feature/spdlog logger #18
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
And wrap it inside a class for easy initialization/making sure all loggers are initialized if anyone wants to add a new subsystem down the line.
I think it should work?
Keeping it as a separate class for now. Will replace Logger when I’m doing working.
I don’t think this was actually being a problem, but it was also a circular dependency.
MSVC complaining about duplicate symbol.
…and nuke the useless constructor.
And remove duplicate code from configuration and controllers.
Lord-Kamina
force-pushed
the
feature/spdlog-logger
branch
from
bd9d371 to
ff45d96
Compare
|
Download the artifacts for this pull request:
This service is provided by nightly.link. These artifacts will expire in 90 days and will not be available for download after that time. |
Lord-Kamina
force-pushed
the
feature/spdlog-logger
branch
2 times, most recently
from
61a625c to
5d465b5
Compare
Several stray files with CRLF endings.
Begin the try block after initializing the logger, so we can use the logger to report exceptions to the console and log file.
In practice, it’s very unlikely this error will ever trigger but sure, let’s make the code analysis happy.
Windows macros strike again! This error in particular is pretty insidious and not very easy to diagnose. Instead of dumb work-arounds, I’m opting to just change the name of these to avoid collisions with macros. - `Song::LoadStatus::ERROR` —> `Song::LoadStatus::PARSERERROR`. - `far —> `farDistance` - `near` —> `nearDistance` That say, we don’t need to worry about if or when a third-party library does `#include <Windows.h>`
A lot of users think this is an important error, and no doubt that would be amplified by printing it in bold with a red background.
Lord-Kamina
force-pushed
the
feature/spdlog-logger
branch
from
5d465b5 to
a6eed49
Compare
Lord-Kamina
force-pushed
the
feature/spdlog-logger
branch
3 times, most recently
from
9de7f72 to
35d0bdc
Compare
Lord-Kamina
force-pushed
the
feature/spdlog-logger
branch
from
35d0bdc to
f7ada10
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Closes Issue(s)
Motivation
More
Additional Notes