extract: Split out API features#2997
Open
MarkY-LunarG wants to merge 2 commits into
Open
Conversation
MarkY-LunarG
added
the
approved-to-run-ci
Contributor
Author
|
@davidd-lunarg , I added you for reviewing the D3D12 side of things. The visual comparison passes, but I would like you to verify. |
mikes-lunarg
requested changes
Jun 9, 2026
mikes-lunarg
left a comment
mikes-lunarg
left a comment
Contributor
There was a problem hiding this comment.
Just a couple of small things, some of them aren't even your fault!
Split out the API-specific functionality into separate feature classes (just like info and convert). NOTE: This does not include OpenXR because it is not a graphics but a compositing API. So that feature is intentionally left out.
MarkY-LunarG
force-pushed
the
split-extract-into-features
branch
from
8e10dc6 to
bd1d715
Compare
Contributor
Author
|
@mikes-lunarg , all changes made. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Split out the API-specific functionality into separate feature classes (just like info and convert).
NOTE: This does not include OpenXR because it is not a graphics but a compositing API. So that feature is intentionally left out.