Treat uvec2 as a potential BDA type#3019
Open
mikes-lunarg wants to merge 1 commit into
Open
Conversation
vkd3d can pass 64-bit buffer device addresses as a 2-component vectors of unsigned 32-bit integers (uvec2). This is apparently a common lowering and explicitly allowed by the GL_EXT_buffer_reference_uvec2 GLSL extension. Therefore, treat uvec2 values (and arrays) as potential BDAs in the forward SPIRV-reflect pass of SpirVParsingUtil::ParseBufferReferences. Add a test case to the SpirVParsingUtil for both uvec2 and uvec2[] paths.
mikes-lunarg
added
the
approved-to-run-ci
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
vkd3d can pass 64-bit buffer device addresses as a 2-component vectors of unsigned 32-bit integers (uvec2). This is apparently a common lowering and explicitly allowed by the GL_EXT_buffer_reference_uvec2 GLSL extension. Therefore, treat uvec2 values (and arrays) as potential BDAs in the forward SPIRV-reflect pass of
SpirVParsingUtil::ParseBufferReferences.
Add a test case to the SpirVParsingUtil for both uvec2 and uvec2[] paths.