Add first index to end of loop#3021
Open
wzchu-lunarg wants to merge 1 commit into
Open
Conversation
LunarG#2679 indicates the loop is incorrect according to the spec. After testing, there are validation errors on replay as the query pools aren't reset. GFXR does the following when setting the state for replay: - Create query pools - Reset query pools - Start "dummy" queries for the queries in active states This fix will result in states being accurate to how they were tracked. However, GFXR simply acknowledges that queries can still read the dummy queries on the first frame after loading the state. Perhaps this will be changed eventually.
wzchu-lunarg
added
the
approved-to-run-ci
davidd-lunarg
approved these changes
Jun 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#2679 indicates the loop is incorrect according to the spec.
After testing, there are validation errors on replay as the query pools aren't reset.
GFXR does the following when setting the state for replay:
This fix will result in states being accurate to how they were tracked. However, GFXR simply acknowledges that queries can still read the dummy queries on the first frame after loading the state. Perhaps this will be changed eventually.
Fixes #2679