Skip to content

Add in WhoScoredParser ability to work with dict with data #948

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
shufinskiy wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Add in WhoScoredParser ability to work with dict with data #948

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 9 additions & 6 deletions socceraction/data/opta/parsers/whoscored.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
import json # type: ignore
import re
from datetime import datetime, timedelta
from typing import Any, Optional
from typing import Any, Optional, Union

from ...base import MissingDataError
from .base import OptaParser, _get_end_x, _get_end_y, assertget
Expand All @@ -20,8 +20,8 @@ class WhoScoredParser(OptaParser):

Parameters
----------
path : str
Path of the data file.
path : Union[str, dict]
Path of the data file of dict with data
competition_id : int
ID of the competition to which the provided data file belongs. If
None, this information is extracted from a field 'competition_id' in
Expand All @@ -36,13 +36,16 @@ class WhoScoredParser(OptaParser):

def __init__( # noqa: C901
self,
path: str,
path: Union[str, dict],
competition_id: Optional[int] = None,
season_id: Optional[int] = None,
game_id: Optional[int] = None,
) -> None:
with open(path, encoding="utf-8") as fh:
self.root = json.load(fh)
if isinstance(path, str):
with open(path, encoding="utf-8") as fh:
self.root = json.load(fh)
else:
self.root = path

if competition_id is None:
try:
Expand Down