Don't attempt to parse different request types: fixes adding new experiences #65
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks @pvdosev - can you review the linter and test feedback? |
|
Agh the test uses json |
|
Hehe love a passing test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #60
The check
if request.content_type == "multipart/form-data" else request.get_json()doesn't work, because the content type in a multipart form data request also includes the separator between the data of the form, like "multipart/form-data; boundary=------------------------vqfqxmgyrMqVTDpDiq7JrB". This changes every request.
Of course, we could parse it with some string separation, which would be pretty simple, but I thought I'd remove the json part completely since we aren't going to be accepting json data there anyway. I can re-add it if we think it's necessary, but I'd say it's easier and more straightforward like this.
This pull request, if applied along with MLH-Fellowship/orientation-project-js-24.FAL.A#24, makes the uploading of data work correctly.