Skip to content

Add VM details#12

Merged
agrare merged 3 commits intoManageIQ:masterfrom
stiwa-uejo:Add-vm-details
Feb 11, 2026
Merged

Add VM details#12
agrare merged 3 commits intoManageIQ:masterfrom
stiwa-uejo:Add-vm-details

Conversation

@stiwa-uejo
Copy link
Copy Markdown
Contributor

@stiwa-uejo stiwa-uejo commented Feb 10, 2026

This PR adds more VM infos:
Description, Hostname, IP Addresses, guest tools, OS info, network interfaces and disks
image
image
image

I thought since i also need to query some APIs for detailed VM configs in full refresh and also in target refresh i placed it now into the base collector to avoid code duplication, idk if there would have been a smarter way.
I tried to figure out how to create vcr and figured since i changed lots of the current API calls i had to perform a new recording, please tell me if you would like me to have created a new spec and not update the old one, or keep it as its now.
And since I'm using a 2 node cluster all the current specs had to be updated with the new cassette.

Regarding the disks, I didn't include type so far, since I think we need to update the Hosts with more attributes and know which datastore is thin/thick, same for cpu type etc
Also snapshot is a story on its own.

@miq-bot add-reviewer @agrare
@miq-bot add-label enhancement

@miq-bot miq-bot requested a review from agrare February 10, 2026 12:11
@miq-bot miq-bot added the enhancement New feature or request label Feb 10, 2026
@stiwa-uejo
Copy link
Copy Markdown
Contributor Author

I thought it would be cool to use provider specific logging, but $proxmox_log seems to conflict with rubocop,
but i see that same logic here https://github.com/ManageIQ/manageiq-providers-vmware/blob/5cbd0feac5aca422ec4173945c4c77280d8a6ed4/app/models/manageiq/providers/vmware/cloud_manager/orchestration_stack.rb#L10
any idea how I'm supposed to use it correctly?

Description, Hostname, IP Addresses, guest tools,
OS info and disks
@agrare
Copy link
Copy Markdown
Member

agrare commented Feb 10, 2026

@stiwa-uejo provider-specific logging is absolutely a good thing, typically we specifically allow these loggers in the rubocop config for the plugin, e.g.: https://github.com/ManageIQ/manageiq-providers-vmware/blob/master/.rubocop_local.yml

@agrare
Copy link
Copy Markdown
Member

agrare commented Feb 10, 2026

@stiwa-uejo I threw a PR in to the core generator to add this automatically in the future: ManageIQ/manageiq#23722

@miq-bot
Copy link
Copy Markdown
Member

miq-bot commented Feb 11, 2026

Checked commits stiwa-uejo/manageiq-providers-proxmox@d8e521f~...e622667 with ruby 3.3.10, rubocop 1.56.3, haml-lint 0.69.0, and yamllint
7 files checked, 0 offenses detected
Everything looks fine. ⭐

@agrare agrare self-assigned this Feb 11, 2026
@agrare agrare merged commit aebbaf3 into ManageIQ:master Feb 11, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants