Conversation
f2a99bb to
a91e7c3
Compare
|
I thought it would be cool to use provider specific logging, but $proxmox_log seems to conflict with rubocop, |
Description, Hostname, IP Addresses, guest tools, OS info and disks
|
@stiwa-uejo provider-specific logging is absolutely a good thing, typically we specifically allow these loggers in the rubocop config for the plugin, e.g.: https://github.com/ManageIQ/manageiq-providers-vmware/blob/master/.rubocop_local.yml |
|
@stiwa-uejo I threw a PR in to the core generator to add this automatically in the future: ManageIQ/manageiq#23722 |
a91e7c3 to
02448b9
Compare
02448b9 to
2353eb3
Compare
app/models/manageiq/providers/proxmox/inventory/collector/target_collection.rb
Outdated
Show resolved
Hide resolved
app/models/manageiq/providers/proxmox/inventory/collector/target_collection.rb
Outdated
Show resolved
Hide resolved
|
Checked commits stiwa-uejo/manageiq-providers-proxmox@d8e521f~...e622667 with ruby 3.3.10, rubocop 1.56.3, haml-lint 0.69.0, and yamllint |
This PR adds more VM infos:



Description, Hostname, IP Addresses, guest tools, OS info, network interfaces and disks
I thought since i also need to query some APIs for detailed VM configs in full refresh and also in target refresh i placed it now into the base collector to avoid code duplication, idk if there would have been a smarter way.
I tried to figure out how to create vcr and figured since i changed lots of the current API calls i had to perform a new recording, please tell me if you would like me to have created a new spec and not update the old one, or keep it as its now.
And since I'm using a 2 node cluster all the current specs had to be updated with the new cassette.
Regarding the disks, I didn't include type so far, since I think we need to update the Hosts with more attributes and know which datastore is thin/thick, same for cpu type etc
Also snapshot is a story on its own.
@miq-bot add-reviewer @agrare
@miq-bot add-label enhancement