Add plugin logger to rubocop allowed global vars#23722
Merged
Fryguy merged 1 commit intoManageIQ:masterfrom Feb 10, 2026
Merged
Add plugin logger to rubocop allowed global vars#23722Fryguy merged 1 commit intoManageIQ:masterfrom
Fryguy merged 1 commit intoManageIQ:masterfrom
Conversation
The plugin logger that is generated should be added to the list of allowed global variables in the `.rubocop_local.yml` config file.
agrare
force-pushed
the
allow_global_vars_plugin_logger
branch
from
b421484 to
8193aa2
Compare
agrare
changed the title
Member
|
Checked commit agrare@8193aa2 with ruby 3.3.10, rubocop 1.56.3, haml-lint 0.69.0, and yamllint |
Fryguy
approved these changes
Feb 10, 2026
Member
|
Good find. |
Member
|
Oh wait I just realized you have to add it to the main plugin code so it knows this is a template to process. |
Member
|
nvm - I didn't see that the template wasn't a new file - it's an existing empty file with just some content added now. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ref: ManageIQ/manageiq-providers-proxmox#12 (comment)