Use no periods for partial phrases, like other providers#17
Merged
Fryguy merged 1 commit intoManageIQ:masterfrom Mar 2, 2026
Conversation
Note, this is fairly inconsistent across providers but when we see inconsistences, we should try to pick which way to go and since most providers have an incomplete sentence in these validation and helper texts, it makes sense to try to keep this non-sentence structure. I was noticing the english message catalog had the same partial sentence with and without the period: ``` msgid "Must start with a letter and contain only letters, numbers, and underscores" msgstr "" msgid "Must start with a letter and contain only letters, numbers, and underscores." msgstr "" ``` See: ManageIQ/manageiq#23665
jrafanie
commented
Mar 2, 2026
| :label => _('Name'), | ||
| :isRequired => true, | ||
| :helperText => _('Must start with a letter and contain only letters, numbers, and underscores.'), | ||
| :helperText => _('Must start with a letter and contain only letters, numbers, and underscores'), |
Member
Author
There was a problem hiding this comment.
See line 20 below... these were duplicated but one had a period.
jrafanie
commented
Mar 2, 2026
| :offText => _('No'), | ||
| :isDisabled => current_state != 'on', | ||
| :helperText => _('Snapshotting the memory is only available if the VM is powered on.') | ||
| :helperText => _('Snapshotting the memory is only available if the VM is powered on') |
Member
Author
There was a problem hiding this comment.
For consistency, I removed the period since this is often a phrase, partial sentence, or command.
Member
|
Checked commit jrafanie@e292560 with ruby 3.3.10, rubocop 1.56.3, haml-lint 0.69.0, and yamllint |
Fryguy
approved these changes
Mar 2, 2026
jrafanie
deleted the
more-consistent-helper-validation-phrases-without-period
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note, this is fairly inconsistent across providers but when we see inconsistences, we should try to pick which way to go and since most providers have an incomplete sentence in these validation and helper texts, it makes sense to try to keep this non-sentence structure.
I was noticing the english message catalog had the same partial sentence with and without the period:
See: ManageIQ/manageiq#23665