Skip to content

Use no periods for partial phrases, like other providers #17

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Fryguy merged 1 commit into from
Mar 2, 2026
Merged

Use no periods for partial phrases, like other providers #17

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions app/models/manageiq/providers/proxmox/infra_manager/vm/operations/snapshot.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ def params_for_create_snapshot
:id => 'name',
:label => _('Name'),
:isRequired => true,
:helperText => _('Must start with a letter and contain only letters, numbers, and underscores.'),
:helperText => _('Must start with a letter and contain only letters, numbers, and underscores'),
Copy link
Copy Markdown
Member Author

@jrafanie jrafanie Mar 2, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See line 20 below... these were duplicated but one had a period.

:validate => [
{:type => 'required'},
{:type => 'pattern', :pattern => '^[a-zA-Z][a-zA-Z0-9_]*$', :message => _('Must start with a letter and contain only letters, numbers, and underscores')}
Expand All @@ -34,7 +34,7 @@ def params_for_create_snapshot
:onText => _('Yes'),
:offText => _('No'),
:isDisabled => current_state != 'on',
:helperText => _('Snapshotting the memory is only available if the VM is powered on.')
:helperText => _('Snapshotting the memory is only available if the VM is powered on')
Copy link
Copy Markdown
Member Author

@jrafanie jrafanie Mar 2, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For consistency, I removed the period since this is often a phrase, partial sentence, or command.

}
]
}
Expand Down