Remove Nuage Network Provider

[agrare]

Drop all references to Nuage, most of these should have been implemented differently anyway.

I see a number of references to e.g.:

          Array [
            "Nuage Zone", 
            11,
          ],

In e.g. app/javascript/spec/ansible-edit-catalog-form/__snapshots__/ansible-edit-catalog-form.spec.js.snap

I'm not sure if these have to be deleted also?

ManageIQ/manageiq#23759

[GilbertCherrie]

@agrare can you run yarn jest -u to update the snaps, you might need to run that to get rid of the snapshot file refrences

[agrare]

This was a good example of using a specific provider just because it happens to support/not-support a feature versus using stub_supports/stub_supports_not

[agrare]

@GilbertCherrie I see a few backtraces but they don't look related to nuage:

 RUNS  app/javascript/spec/ansible-repository-form/helpers.spec.js
 RUNS  app/javascript/spec/http_api.spec.js
 RUNS  app/javascript/spec/ansible-playbook-workflow/ansible-playbook-workflow.spec.js
 RUNS  app/javascript/spec/textual_summary/tests/simple_table.test.js
 RUNS  app/javascript/spec/textual_summary/tests/textual_summary.test.js
 RUNS  app/javascript/spec/flavor-form/flavor-form.spec.js
 RUNS  app/javascript/spec/pxe-iso-image-form/pxe-iso-image-form.spec.js
 RUNS  app/javascript/spec/service-form/edit-service-form.spec.js
  console.error
    Warning: React does not recognize the `loadingMessage` prop on a DOM element. If you intentionally want it to appear in the DOM as a custom attribute, spell it as lowercase `loadingmessage` instead. If you accidentally passed it from a parent component, remove it from the DOM element.
        in select (created by Select)
        in div (created by Select)
        in div (created by Select)
        in div (created by Select)
        in Select (created by ClearedSelect)
        in ClearedSelect (created by Select)

In the end it says everything passes and no files are modified

A worker process has failed to exit gracefully and has been force exited. This is likely caused by tests leaking due to improper teardown. Try running with --detectOpenHandles to find leaks.
Test Suites: 159 passed, 159 total
Tests:       704 passed, 704 total
Snapshots:   306 passed, 306 total
Time:        10.996 s
Ran all test suites.

[GilbertCherrie]

@agrare don't worry about the warnings, it's strange that none of the files were changed. We might need to delete the nuage provider references somewhere else

[GilbertCherrie]

@agrare oh it looks like it is just in app/javascript/spec/ansible-edit-catalog-form/mockdata.js, which is our spec file. This can just be deleted and that should update the snapshot files

[agrare]

Okay I did that @GilbertCherrie there are still a number of these, if there is something else I need to do let me know.

[GilbertCherrie]

@agrare I checked out your branch and it looks fine now. If you are referring to the references in the language json files don't worry about those. Those don't affect anything and should be updated when we update the translation files.

[Fryguy]

@GilbertCherrie assigning this to you - when you're ready feel free to merge - I'll monitor and then merge the core PR when this is in.

[agrare]

NOTE this now depends on https://github.com/ManageIQ/manageiq/pull/23792/changes#diff-8d286308b75ae7dc8a266753732b0c1709d33293518c479765e34cadf8207910R281

[agrare]

I was able to drop that app/javascript/helpers/network-providers.js as it was only used in app/javascript/spec/network-router-form/network-router-form.spec.js and could be easily removed from there

[agrare]

I don't think the whitesource failure is related to this PR

[miq-bot]

Checked commits agrare/manageiq-ui-classic@1068246~...fa2671b with ruby 3.3.10, rubocop 1.86.0, haml-lint 0.72.0, and yamllint 1.37.1
4 files checked, 3 offenses detected

app/helpers/application_helper/toolbar/ems_network_center.rb

• ❗ - Line 26, Col 12 - Layout/MultilineMethodCallBraceLayout - Closing method call brace must be on the line after the last argument when opening brace is on a separate line from the first argument.

app/helpers/application_helper/toolbar/ems_networks_center.rb

• ❗ - Line 26, Col 65 - Layout/MultilineMethodCallBraceLayout - Closing method call brace must be on the line after the last argument when opening brace is on a separate line from the first argument.
• ❗ - Line 35, Col 31 - Layout/MultilineMethodCallBraceLayout - Closing method call brace must be on the line after the last argument when opening brace is on a separate line from the first argument.