Merged
Conversation
alex-hunt-materialize
force-pushed
the
load_balancers
branch
from
c6eeed2 to
25be1f3
Compare
Contributor
Author
|
(force push was just because I forgot the README.md) |
bobbyiliev
approved these changes
Mar 31, 2025
Collaborator
bobbyiliev
left a comment
bobbyiliev
left a comment
There was a problem hiding this comment.
Looks good! Just tested this locally and it worked well.
As a follow up should we also update the GCP CI test project?
Contributor
Author
Yes, we should. We should also do that for AWS. These tests should probably also be updated for TLS support and lgalloc. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Support creating load balancers for outside-K8S connections to balancerd and the console.
Create internal load balancers by default.
Resolves https://github.com/MaterializeInc/cloud/issues/10879